Bug 40180 - Missing Cypress tests for 'Holds to pull' library filters
Summary: Missing Cypress tests for 'Holds to pull' library filters
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Jonathan Druart
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 40118 40174
Blocks: 40181
  Show dependency treegraph
 
Reported: 2025-06-18 21:24 UTC by Jonathan Druart
Modified: 2025-07-23 07:45 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 40180: (bug 40118 follow-up) Add Cypress tests (18.27 KB, patch)
2025-06-19 10:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40180: Add tests for insertSampleHold (11.75 KB, patch)
2025-06-19 10:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40180: (bug 40118 follow-up) Add Cypress tests (18.19 KB, patch)
2025-07-10 12:21 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40180: Add tests for insertSampleHold (11.62 KB, patch)
2025-07-10 12:21 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40180: Improve deleteSampleObjects (8.15 KB, patch)
2025-07-10 12:21 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40180: (bug 40118 follow-up) Add Cypress tests (20.35 KB, patch)
2025-07-10 12:28 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40180: Add tests for insertSampleHold (11.62 KB, patch)
2025-07-10 12:28 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40180: Improve deleteSampleObjects (8.15 KB, patch)
2025-07-10 12:28 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40180: (bug 40118 follow-up) Add Cypress tests (20.35 KB, patch)
2025-07-17 16:05 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40180: Add tests for insertSampleHold (11.62 KB, patch)
2025-07-17 16:06 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40180: Improve deleteSampleObjects (8.15 KB, patch)
2025-07-17 16:06 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40180: (bug 40118 follow-up) Add Cypress tests (20.40 KB, patch)
2025-07-17 16:36 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40180: Add tests for insertSampleHold (11.67 KB, patch)
2025-07-17 16:36 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40180: Improve deleteSampleObjects (8.20 KB, patch)
2025-07-17 16:36 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40180: (bug 40118 follow-up) Add Cypress tests (20.46 KB, patch)
2025-07-18 11:23 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 40180: Add tests for insertSampleHold (11.74 KB, patch)
2025-07-18 11:23 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 40180: Improve deleteSampleObjects (8.27 KB, patch)
2025-07-18 11:23 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 40180: Fix Cypress test (1.04 KB, patch)
2025-07-23 07:35 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-06-18 21:24:31 UTC
Bug 40118 is going to be pushed without tests to cover the changes. We should remedy to that
Comment 1 Jonathan Druart 2025-06-19 10:53:06 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2025-06-19 10:53:08 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2025-06-19 10:54:46 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2025-07-10 12:21:29 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2025-07-10 12:21:31 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2025-07-10 12:21:33 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2025-07-10 12:28:04 UTC
Created attachment 183933 [details] [review]
Bug 40180: (bug 40118 follow-up) Add Cypress tests

This patch heavily reuses what has been introduced by the previous
patches in the tree, and add a insertSampleHold task to be reusable
easily in other tests.

Test plan:
All Cypress tests must pass
Comment 8 Jonathan Druart 2025-07-10 12:28:06 UTC
Created attachment 183934 [details] [review]
Bug 40180: Add tests for insertSampleHold
Comment 9 Jonathan Druart 2025-07-10 12:28:08 UTC
Created attachment 183935 [details] [review]
Bug 40180: Improve deleteSampleObjects

We want the task to accept an Object or an Array of Objects
Comment 10 Jonathan Druart 2025-07-17 16:05:59 UTC
Created attachment 184221 [details] [review]
Bug 40180: (bug 40118 follow-up) Add Cypress tests

This patch heavily reuses what has been introduced by the previous
patches in the tree, and add a insertSampleHold task to be reusable
easily in other tests.

Test plan:
All Cypress tests must pass
Comment 11 Jonathan Druart 2025-07-17 16:06:01 UTC
Created attachment 184222 [details] [review]
Bug 40180: Add tests for insertSampleHold
Comment 12 Jonathan Druart 2025-07-17 16:06:04 UTC
Created attachment 184223 [details] [review]
Bug 40180: Improve deleteSampleObjects

We want the task to accept an Object or an Array of Objects
Comment 13 Owen Leonard 2025-07-17 16:36:08 UTC
Created attachment 184227 [details] [review]
Bug 40180: (bug 40118 follow-up) Add Cypress tests

This patch heavily reuses what has been introduced by the previous
patches in the tree, and add a insertSampleHold task to be reusable
easily in other tests.

Test plan:
All Cypress tests must pass

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 14 Owen Leonard 2025-07-17 16:36:11 UTC
Created attachment 184228 [details] [review]
Bug 40180: Add tests for insertSampleHold

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 15 Owen Leonard 2025-07-17 16:36:13 UTC
Created attachment 184229 [details] [review]
Bug 40180: Improve deleteSampleObjects

We want the task to accept an Object or an Array of Objects

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 16 Martin Renvoize (ashimema) 2025-07-18 11:23:29 UTC
Created attachment 184334 [details] [review]
Bug 40180: (bug 40118 follow-up) Add Cypress tests

This patch heavily reuses what has been introduced by the previous
patches in the tree, and add a insertSampleHold task to be reusable
easily in other tests.

Test plan:
All Cypress tests must pass

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 17 Martin Renvoize (ashimema) 2025-07-18 11:23:31 UTC
Created attachment 184335 [details] [review]
Bug 40180: Add tests for insertSampleHold

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 18 Martin Renvoize (ashimema) 2025-07-18 11:23:33 UTC
Created attachment 184336 [details] [review]
Bug 40180: Improve deleteSampleObjects

We want the task to accept an Object or an Array of Objects

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 19 Lucas Gass (lukeg) 2025-07-21 20:03:23 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 20 Jonathan Druart 2025-07-23 07:35:08 UTC
Created attachment 184532 [details] [review]
Bug 40180: Fix Cypress test

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 21 Jonathan Druart 2025-07-23 07:45:29 UTC
(In reply to Jonathan Druart from comment #20)
> Created attachment 184532 [details] [review] [review]
> Bug 40180: Fix Cypress test
> 
> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Pushed to main.