Bug 40118 is going to be pushed without tests to cover the changes. We should remedy to that
Created attachment 183375 [details] [review] Bug 40180: (bug 40118 follow-up) Add Cypress tests This patch heavily reuses what has been introduced by the previous patches in the tree, and add a insertSampleHold task to be reusable easily in other tests. Test plan: All Cypress tests must pass
Created attachment 183376 [details] [review] Bug 40180: Add tests for insertSampleHold
In case of conflict, the tree is available at https://gitlab.com/joubu/Koha/-/commits/bug_40180
Created attachment 183930 [details] [review] Bug 40180: (bug 40118 follow-up) Add Cypress tests This patch heavily reuses what has been introduced by the previous patches in the tree, and add a insertSampleHold task to be reusable easily in other tests. Test plan: All Cypress tests must pass
Created attachment 183931 [details] [review] Bug 40180: Add tests for insertSampleHold
Created attachment 183932 [details] [review] Bug 40180: Improve deleteSampleObjects We want the task to accept an Object or an Array of Objects
Created attachment 183933 [details] [review] Bug 40180: (bug 40118 follow-up) Add Cypress tests This patch heavily reuses what has been introduced by the previous patches in the tree, and add a insertSampleHold task to be reusable easily in other tests. Test plan: All Cypress tests must pass
Created attachment 183934 [details] [review] Bug 40180: Add tests for insertSampleHold
Created attachment 183935 [details] [review] Bug 40180: Improve deleteSampleObjects We want the task to accept an Object or an Array of Objects
Created attachment 184221 [details] [review] Bug 40180: (bug 40118 follow-up) Add Cypress tests This patch heavily reuses what has been introduced by the previous patches in the tree, and add a insertSampleHold task to be reusable easily in other tests. Test plan: All Cypress tests must pass
Created attachment 184222 [details] [review] Bug 40180: Add tests for insertSampleHold
Created attachment 184223 [details] [review] Bug 40180: Improve deleteSampleObjects We want the task to accept an Object or an Array of Objects
Created attachment 184227 [details] [review] Bug 40180: (bug 40118 follow-up) Add Cypress tests This patch heavily reuses what has been introduced by the previous patches in the tree, and add a insertSampleHold task to be reusable easily in other tests. Test plan: All Cypress tests must pass Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 184228 [details] [review] Bug 40180: Add tests for insertSampleHold Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 184229 [details] [review] Bug 40180: Improve deleteSampleObjects We want the task to accept an Object or an Array of Objects Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 184334 [details] [review] Bug 40180: (bug 40118 follow-up) Add Cypress tests This patch heavily reuses what has been introduced by the previous patches in the tree, and add a insertSampleHold task to be reusable easily in other tests. Test plan: All Cypress tests must pass Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 184335 [details] [review] Bug 40180: Add tests for insertSampleHold Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 184336 [details] [review] Bug 40180: Improve deleteSampleObjects We want the task to accept an Object or an Array of Objects Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Nice work everyone! Pushed to main for 25.11
Created attachment 184532 [details] [review] Bug 40180: Fix Cypress test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(In reply to Jonathan Druart from comment #20) > Created attachment 184532 [details] [review] [review] > Bug 40180: Fix Cypress test > > Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to main.