Bug 40168

Summary: afterEach not called in KohaTable cypress tests
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: Signed Off --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low    
Version: unspecified   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 40127    
Bug Blocks: 40170    
Attachments: Bug 40168: Restore afterEach in KohaTable Cypress tests
Bug 40168: Remove cleanup() call from afterEach
Bug 40168: Restore afterEach in KohaTable Cypress tests
Bug 40168: Remove cleanup() call from afterEach

Description Jonathan Druart 2025-06-18 20:03:57 UTC

    
Comment 1 Jonathan Druart 2025-06-18 20:17:13 UTC
Created attachment 183348 [details] [review]
Bug 40168: Restore afterEach in KohaTable Cypress tests

We defined an anonymous function inside an arrow function, and Cypress does not call it.

Test plan:
Set AlwaysShowHoldingsTableFilters to "Do not"
Run t/cypress/integration/KohaTable/Holdings_spec.ts:
  yarn cypress run --spec t/cypress/integration/KohaTable/Holdings_spec.ts

When done, have a look at the value of AlwaysShowHoldingsTableFilters
=> without this patch it has been modified (not restored) and is set to
"Do"
=> With this patch applied the original value is restored at the end of
the tests (actually the end of each test)
Comment 2 Jonathan Druart 2025-06-18 20:17:16 UTC
Created attachment 183349 [details] [review]
Bug 40168: Remove cleanup() call from afterEach
Comment 3 David Nind 2025-06-18 21:25:26 UTC
Created attachment 183357 [details] [review]
Bug 40168: Restore afterEach in KohaTable Cypress tests

We defined an anonymous function inside an arrow function, and Cypress does not call it.

Test plan:
Set AlwaysShowHoldingsTableFilters to "Do not"
Run t/cypress/integration/KohaTable/Holdings_spec.ts:
  yarn cypress run --spec t/cypress/integration/KohaTable/Holdings_spec.ts

When done, have a look at the value of AlwaysShowHoldingsTableFilters
=> without this patch it has been modified (not restored) and is set to
"Do"
=> With this patch applied the original value is restored at the end of
the tests (actually the end of each test)

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2025-06-18 21:25:29 UTC
Created attachment 183358 [details] [review]
Bug 40168: Remove cleanup() call from afterEach

Signed-off-by: David Nind <david@davidnind.com>