"build_items_table is not defined"
Created attachment 183185 [details] [review] Bug 40127: Move build_items_table outside of document.ready So it's not delayed and we catch have the error in the Cypress test. Otherwise the error appear too late (in the after each) and the test does not fail
Created attachment 183186 [details] [review] Bug 40127: Add a Cypress test
Created attachment 183187 [details] [review] Bug 40127: Remove JS error from the biblio detail page when no items "build_items_table is not defined" We should not try to build the items table if there are no items. Test plan: Go to the bibliographic detail page of a biblio without items You should not see errors in the browser's console Go to the bibliographic detail page of a biblio with items You should not see errors in the browser's console The table should be displayed and the different features should work as before
Created attachment 183188 [details] [review] Bug 40127: Move build_items_table outside of document.ready So it's not delayed and we catch have the error in the Cypress test. Otherwise the error appear too late (in the after each) and the test does not fail
Created attachment 183189 [details] [review] Bug 40127: Add a Cypress test
Created attachment 183190 [details] [review] Bug 40127: Remove JS error from the biblio detail page when no items "build_items_table is not defined" We should not try to build the items table if there are no items. Test plan: Go to the bibliographic detail page of a biblio without items You should not see errors in the browser's console Go to the bibliographic detail page of a biblio with items You should not see errors in the browser's console The table should be displayed and the different features should work as before
Created attachment 183228 [details] [review] Bug 40127: Move build_items_table outside of document.ready So it's not delayed and we catch have the error in the Cypress test. Otherwise the error appear too late (in the after each) and the test does not fail Signed-off-by: David Nind <david@davidnind.com>
Created attachment 183229 [details] [review] Bug 40127: Add a Cypress test Signed-off-by: David Nind <david@davidnind.com>
Created attachment 183230 [details] [review] Bug 40127: Remove JS error from the biblio detail page when no items "build_items_table is not defined" We should not try to build the items table if there are no items. Test plan: Go to the bibliographic detail page of a biblio without items You should not see errors in the browser's console Go to the bibliographic detail page of a biblio with items You should not see errors in the browser's console The table should be displayed and the different features should work as before Signed-off-by: David Nind <david@davidnind.com>
Created attachment 183283 [details] [review] Bug 40127: Add a Cypress test Signed-off-by: David Nind <david@davidnind.com>
Removed ".only" from cypress test.