Created attachment 183348 [details] [review] Bug 40168: Restore afterEach in KohaTable Cypress tests We defined an anonymous function inside an arrow function, and Cypress does not call it. Test plan: Set AlwaysShowHoldingsTableFilters to "Do not" Run t/cypress/integration/KohaTable/Holdings_spec.ts: yarn cypress run --spec t/cypress/integration/KohaTable/Holdings_spec.ts When done, have a look at the value of AlwaysShowHoldingsTableFilters => without this patch it has been modified (not restored) and is set to "Do" => With this patch applied the original value is restored at the end of the tests (actually the end of each test)
Created attachment 183349 [details] [review] Bug 40168: Remove cleanup() call from afterEach
Created attachment 183357 [details] [review] Bug 40168: Restore afterEach in KohaTable Cypress tests We defined an anonymous function inside an arrow function, and Cypress does not call it. Test plan: Set AlwaysShowHoldingsTableFilters to "Do not" Run t/cypress/integration/KohaTable/Holdings_spec.ts: yarn cypress run --spec t/cypress/integration/KohaTable/Holdings_spec.ts When done, have a look at the value of AlwaysShowHoldingsTableFilters => without this patch it has been modified (not restored) and is set to "Do" => With this patch applied the original value is restored at the end of the tests (actually the end of each test) Signed-off-by: David Nind <david@davidnind.com>
Created attachment 183358 [details] [review] Bug 40168: Remove cleanup() call from afterEach Signed-off-by: David Nind <david@davidnind.com>
Created attachment 183865 [details] [review] Bug 40168: Restore afterEach in KohaTable Cypress tests We defined an anonymous function inside an arrow function, and Cypress does not call it. Test plan: Set AlwaysShowHoldingsTableFilters to "Do not" Run t/cypress/integration/KohaTable/Holdings_spec.ts: yarn cypress run --spec t/cypress/integration/KohaTable/Holdings_spec.ts When done, have a look at the value of AlwaysShowHoldingsTableFilters => without this patch it has been modified (not restored) and is set to "Do" => With this patch applied the original value is restored at the end of the tests (actually the end of each test) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Created attachment 183866 [details] [review] Bug 40168: Remove cleanup() call from afterEach Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x
I'm looking at this for 24.11.x but dependencies are deep
In reply to Fridolin Somers from comment #9) > I'm looking at this for 24.11.x but dependencies are deep It simply removes - () =>(
Pushed to 24.11.x for 24.11.08