Summary: | Remove jQuery from js/fetch/http-client.js | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Templates | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | Needs documenting --- | QA Contact: | Pedro Amorim <pedro.amorim> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | dcook, fridolin.somers, pedro.amorim |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.11.00,25.05.02
|
Circulation function: | |
Bug Depends on: | |||
Bug Blocks: | 40173 | ||
Attachments: |
Bug 40172: Replace jQuery with vanilla JS in js/fetch/http-client.js
Bug 40172: Replace jQuery with vanilla JS in js/fetch/http-client.js Bug 40172: Replace jQuery with vanilla JS in js/fetch/http-client.js |
Description
Jonathan Druart
2025-06-18 20:48:23 UTC
Created attachment 183353 [details] [review] Bug 40172: Replace jQuery with vanilla JS in js/fetch/http-client.js So that we can reuse it from somewhere else. The current need is to be able to reuse it from Cypress tests. Test plan: Try to hit several places where APIClient is used: * Syspref edition * Translation of item type description (be aware of bug 40161) * Delete of cover images * checkin, renew from the checkout list * etc. Note that this does not affect Vue components. (In reply to Jonathan Druart from comment #0) > We do not really need jQuery, it can be replace with vanilla JavaScript. This makes me very happy :D I just tested with the syspref endpoint, but that does test all the changes. Test plan: 0. Apply the patch 1. Log into staff interface 2. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=opacuserjs&ok=Search 3. Add a JS comment 4. Note that it succeeds 5. In a separate tab, log out of the staff interface 6. Try to update the JS comment 7. Note that the message "Error: Forbidden" appears at the top of the page Created attachment 183361 [details] [review] Bug 40172: Replace jQuery with vanilla JS in js/fetch/http-client.js So that we can reuse it from somewhere else. The current need is to be able to reuse it from Cypress tests. Test plan: Try to hit several places where APIClient is used: * Syspref edition * Translation of item type description (be aware of bug 40161) * Delete of cover images * checkin, renew from the checkout list * etc. Note that this does not affect Vue components. Signed-off-by: David Cook <dcook@prosentient.com.au> Created attachment 183871 [details] [review] Bug 40172: Replace jQuery with vanilla JS in js/fetch/http-client.js So that we can reuse it from somewhere else. The current need is to be able to reuse it from Cypress tests. Test plan: Try to hit several places where APIClient is used: * Syspref edition * Translation of item type description (be aware of bug 40161) * Delete of cover images * checkin, renew from the checkout list * etc. Note that this does not affect Vue components. Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x Enhancement not pushed to 24.11.x |