We do not really need jQuery, it can be replace with vanilla JavaScript.
Created attachment 183353 [details] [review] Bug 40172: Replace jQuery with vanilla JS in js/fetch/http-client.js So that we can reuse it from somewhere else. The current need is to be able to reuse it from Cypress tests. Test plan: Try to hit several places where APIClient is used: * Syspref edition * Translation of item type description (be aware of bug 40161) * Delete of cover images * checkin, renew from the checkout list * etc. Note that this does not affect Vue components.
(In reply to Jonathan Druart from comment #0) > We do not really need jQuery, it can be replace with vanilla JavaScript. This makes me very happy :D
I just tested with the syspref endpoint, but that does test all the changes. Test plan: 0. Apply the patch 1. Log into staff interface 2. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=opacuserjs&ok=Search 3. Add a JS comment 4. Note that it succeeds 5. In a separate tab, log out of the staff interface 6. Try to update the JS comment 7. Note that the message "Error: Forbidden" appears at the top of the page
Created attachment 183361 [details] [review] Bug 40172: Replace jQuery with vanilla JS in js/fetch/http-client.js So that we can reuse it from somewhere else. The current need is to be able to reuse it from Cypress tests. Test plan: Try to hit several places where APIClient is used: * Syspref edition * Translation of item type description (be aware of bug 40161) * Delete of cover images * checkin, renew from the checkout list * etc. Note that this does not affect Vue components. Signed-off-by: David Cook <dcook@prosentient.com.au>