Uncaught (in promise) TypeError: table.row is undefined
Created attachment 183327 [details] [review] Bug 40161: (bug 38255 follow-up) Fix item type translation JS error Uncaught (in promise) TypeError: table.row is undefined We need to use the DataTable object. Test plan: Have several languages installed Edit an item type and click "Translate into other languages" to open the modal Translate into another language and note that: Without this patch you get a JS error in the browser console and the row is not added to the table With this patch applied the row is added correctly with your translation
Created attachment 183328 [details] [review] Bug 40161: (bug 38255 follow-up) Fix item type translation JS error Uncaught (in promise) TypeError: table.row is undefined We need to use the DataTable object. Test plan: Have several languages installed Edit an item type and click "Translate into other languages" to open the modal Translate into another language and note that: Without this patch you get a JS error in the browser console and the row is not added to the table With this patch applied the row is added correctly with your translation Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 183464 [details] [review] Bug 40161: (bug 38255 follow-up) Fix item type translation JS error Uncaught (in promise) TypeError: table.row is undefined We need to use the DataTable object. Test plan: Have several languages installed Edit an item type and click "Translate into other languages" to open the modal Translate into another language and note that: Without this patch you get a JS error in the browser console and the row is not added to the table With this patch applied the row is added correctly with your translation Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Just curious: Why change var to let here? It does not make any difference here (same block, same function). Do we have some rule about it?
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x for 25.05.01
Depends on Bug 38255 not in 24.11.x
Bug fix, no changes to the manual required.