Bug 40161 - New translation not displayed when translating an item type
Summary: New translation not displayed when translating an item type
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low major
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords: rel_25_05_candidate
Depends on: 38255
Blocks:
  Show dependency treegraph
 
Reported: 2025-06-18 11:41 UTC by Jonathan Druart
Modified: 2025-06-18 12:42 UTC (History)
0 users

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 40161: (bug 38255 follow-up) Fix item type translation JS error (2.46 KB, patch)
2025-06-18 11:45 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40161: (bug 38255 follow-up) Fix item type translation JS error (2.51 KB, patch)
2025-06-18 12:42 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-06-18 11:41:17 UTC
Uncaught (in promise) TypeError: table.row is undefined
Comment 1 Jonathan Druart 2025-06-18 11:45:58 UTC
Created attachment 183327 [details] [review]
Bug 40161: (bug 38255 follow-up) Fix item type translation JS error

Uncaught (in promise) TypeError: table.row is undefined

We need to use the DataTable object.

Test plan:
Have several languages installed
Edit an item type and click "Translate into other languages" to open the
modal
Translate into another language and note that:
Without this patch you get a JS error in the browser console and the
row is not added to the table
With this patch applied the row is added correctly with your translation
Comment 2 Owen Leonard 2025-06-18 12:42:14 UTC
Created attachment 183328 [details] [review]
Bug 40161: (bug 38255 follow-up) Fix item type translation JS error

Uncaught (in promise) TypeError: table.row is undefined

We need to use the DataTable object.

Test plan:
Have several languages installed
Edit an item type and click "Translate into other languages" to open
the modal
Translate into another language and note that:
Without this patch you get a JS error in the browser console and the
row is not added to the table
With this patch applied the row is added correctly with your translation

Signed-off-by: Owen Leonard <oleonard@myacpl.org>