Bug 40372

Summary: api/v1/holds.t generates a warning
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: Pushed to oldstable --- QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: minor    
Priority: P5 - low CC: fridolin.somers, martin.renvoize
Version: unspecified   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.02,24.11.08
Circulation function:
Bug Depends on:    
Bug Blocks: 40444    
Attachments: Bug 40372: Remove warning from api/v1/holds.t
Bug 40372: Remove warning from api/v1/holds.t
Bug 40372: Remove warning from api/v1/holds.t

Description Jonathan Druart 2025-07-15 09:04:52 UTC
t/db_dependent/api/v1/holds.t .. 1/16 No reserves HOLD_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 602.
Comment 1 Jonathan Druart 2025-07-15 09:06:53 UTC
Created attachment 184075 [details] [review]
Bug 40372: Remove warning from api/v1/holds.t

t/db_dependent/api/v1/holds.t .. 1/16 No reserves HOLD_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 602.

We do not test the notification here, we can simply ignore the letters
code
Comment 2 David Nind 2025-07-17 22:05:18 UTC
Created attachment 184242 [details] [review]
Bug 40372: Remove warning from api/v1/holds.t

t/db_dependent/api/v1/holds.t .. 1/16 No reserves HOLD_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 602.

We do not test the notification here, we can simply ignore the letters
code

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize (ashimema) 2025-07-18 12:04:32 UTC
Created attachment 184356 [details] [review]
Bug 40372: Remove warning from api/v1/holds.t

t/db_dependent/api/v1/holds.t .. 1/16 No reserves HOLD_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 602.

We do not test the notification here, we can simply ignore the letters
code

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 4 Lucas Gass (lukeg) 2025-07-18 17:11:53 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 5 Paul Derscheid 2025-07-24 08:20:59 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 6 Fridolin Somers 2025-08-01 13:32:57 UTC
Not for 24.11.x
Comment 7 Fridolin Somers 2025-08-01 13:36:36 UTC
(In reply to Fridolin Somers from comment #6)
> Not for 24.11.x

Erratum now i see it.
Comment 8 Fridolin Somers 2025-08-01 13:36:45 UTC
Pushed to 24.11.x for 24.11.08