Summary: | Remove legacy "pre-wrap" versions (was Patron/Borrower_Discharge.t generates warnings) | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | Pushed to oldstable --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, martin.renvoize |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.11.00,25.05.02,24.11.08
|
Circulation function: | |
Bug Depends on: | 9210 | ||
Bug Blocks: | 40444 | ||
Attachments: |
Bug 40407: Remove legacy "pre-wrap" versions
Bug 40407: Remove legacy "pre-wrap" versions Bug 40407: Remove legacy "pre-wrap" versions |
Description
Jonathan Druart
2025-07-16 10:17:39 UTC
From https://css-tricks.com/snippets/css/make-pre-text-wrap/ /* Browser specific (not valid) styles to make preformatted text wrap */ pre { white-space: pre-wrap; /* css-3 */ white-space: -moz-pre-wrap; /* Mozilla, since 1999 */ white-space: -pre-wrap; /* Opera 4-6 */ white-space: -o-pre-wrap; /* Opera 7 */ word-wrap: break-word; /* Internet Explorer 5.5+ */ } ... I think it's now safe to remove the backward compatibility versions and simply keep pre-wrap. Created attachment 184133 [details] [review] Bug 40407: Remove legacy "pre-wrap" versions From https://css-tricks.com/snippets/css/make-pre-text-wrap/ /* Browser specific (not valid) styles to make preformatted text wrap */ pre { white-space: pre-wrap; /* css-3 */ white-space: -moz-pre-wrap; /* Mozilla, since 1999 */ white-space: -pre-wrap; /* Opera 4-6 */ white-space: -o-pre-wrap; /* Opera 7 */ word-wrap: break-word; /* Internet Explorer 5.5+ */ } ... I think it's now safe to remove the backward compatibility versions and simply keep pre-wrap. Test plan (from bug 921)0: * place a hold on a title with a very very long title or author * mark it as "waiting for pickup" by doing a checkin * go to command line interface, and run * misc/cronjobs/gather_print_notices.pl /tmp * misc/cronjobs/printoverdues.sh /tmp * if your title/author is long enough, it's splitted on 2 lines with this patch (it is not before this patch) It will also remove the warnings from t/db_dependent/Patron/Borrower_Discharge.t WARNING: Ignored `white-space: -moz-pre-wrap` at 6:14, invalid value. WARNING: Ignored `white-space: -o-pre-wrap` at 7:14, invalid value. WARNING: Ignored `word-wrap: break-work` at 8:14, invalid value. Created attachment 184299 [details] [review] Bug 40407: Remove legacy "pre-wrap" versions From https://css-tricks.com/snippets/css/make-pre-text-wrap/ /* Browser specific (not valid) styles to make preformatted text wrap */ pre { white-space: pre-wrap; /* css-3 */ white-space: -moz-pre-wrap; /* Mozilla, since 1999 */ white-space: -pre-wrap; /* Opera 4-6 */ white-space: -o-pre-wrap; /* Opera 7 */ word-wrap: break-word; /* Internet Explorer 5.5+ */ } ... I think it's now safe to remove the backward compatibility versions and simply keep pre-wrap. Test plan (from bug 921)0: * place a hold on a title with a very very long title or author * mark it as "waiting for pickup" by doing a checkin * go to command line interface, and run * misc/cronjobs/gather_print_notices.pl /tmp * misc/cronjobs/printoverdues.sh /tmp * if your title/author is long enough, it's splitted on 2 lines with this patch (it is not before this patch) It will also remove the warnings from t/db_dependent/Patron/Borrower_Discharge.t WARNING: Ignored `white-space: -moz-pre-wrap` at 6:14, invalid value. WARNING: Ignored `white-space: -o-pre-wrap` at 7:14, invalid value. WARNING: Ignored `word-wrap: break-work` at 8:14, invalid value. Signed-off-by: David Nind <david@davidnind.com> Created attachment 184363 [details] [review] Bug 40407: Remove legacy "pre-wrap" versions From https://css-tricks.com/snippets/css/make-pre-text-wrap/ /* Browser specific (not valid) styles to make preformatted text wrap */ pre { white-space: pre-wrap; /* css-3 */ white-space: -moz-pre-wrap; /* Mozilla, since 1999 */ white-space: -pre-wrap; /* Opera 4-6 */ white-space: -o-pre-wrap; /* Opera 7 */ word-wrap: break-word; /* Internet Explorer 5.5+ */ } ... I think it's now safe to remove the backward compatibility versions and simply keep pre-wrap. Test plan (from bug 921)0: * place a hold on a title with a very very long title or author * mark it as "waiting for pickup" by doing a checkin * go to command line interface, and run * misc/cronjobs/gather_print_notices.pl /tmp * misc/cronjobs/printoverdues.sh /tmp * if your title/author is long enough, it's splitted on 2 lines with this patch (it is not before this patch) It will also remove the warnings from t/db_dependent/Patron/Borrower_Discharge.t WARNING: Ignored `white-space: -moz-pre-wrap` at 6:14, invalid value. WARNING: Ignored `white-space: -o-pre-wrap` at 7:14, invalid value. WARNING: Ignored `word-wrap: break-work` at 8:14, invalid value. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Also agree here.. Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x Pushed to 24.11.x for 24.11.08 |