Bug 40549

Summary: Warnings generated when using Import Patrons tool
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: ToolsAssignee: Nick Clemens (kidclamp) <nick>
Status: Pushed to main --- QA Contact: Tomás Cohen Arazi (tcohen) <tomascohen>
Severity: normal    
Priority: P5 - low CC: lucas
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:
Attachments: Bug 40549: Silence two warnings in patron import tool
Bug 40549: Silence two warnings in patron import tool

Description Nick Clemens (kidclamp) 2025-07-30 11:29:59 UTC
To recreate:
1 - Tail the logs in a terminal:
    tail -f /var/log/koha/kohadev/*.log
2 - Browse to Tools->IMport patrons
3 - Note warning when loading the page:
    Use of uninitialized value $uploadborrowers in concatenation (.) or string at /kohadevbox/koha/tools/import_borrowers.pl line 105.
4 - Upload a patron file, under: Preserve existing borrowers 
    "If matching record is already in the borrowers table:" choose "Ignore..."
5 - Import the file
6 - Note an warning:
    Use of uninitialized value $update_dateexpiry in string eq at /kohadevbox/koha/tools/import_borrowers.pl line 113.
Comment 1 Nick Clemens (kidclamp) 2025-07-30 11:32:17 UTC
Created attachment 184862 [details] [review]
Bug 40549: Silence two warnings in patron import tool

To test:
1 - Tail the logs in a terminal:
    tail -f /var/log/koha/kohadev/*.log
2 - Browse to Tools->IMport patrons
3 - Note warning when loading the page:
    Use of uninitialized value $uploadborrowers in concatenation (.) or string at /kohadevbox/koha/tools/import_borrowers.pl line 105.
4 - Upload a patron file, under: Preserve existing borrowers
    "If matching record is already in the borrowers table:" choose "Ignore..."
5 - Import the file
6 - Note an warning:
    Use of uninitialized value $update_dateexpiry in string eq at /kohadevbox/koha/tools/import_borrowers.pl line 113.
7 - Apply patch, restart all
8 - Reload the tool
9 - Note no warning
10 - Upload the file again, same settings
11 - Note no warning
12 - Sign off!

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 2 Nick Clemens (kidclamp) 2025-07-30 11:32:35 UTC
Trivial, self SO, moving to QA
Comment 3 Tomás Cohen Arazi (tcohen) 2025-07-30 12:46:28 UTC
Created attachment 184885 [details] [review]
Bug 40549: Silence two warnings in patron import tool

To test:
1 - Tail the logs in a terminal:
    tail -f /var/log/koha/kohadev/*.log
2 - Browse to Tools->IMport patrons
3 - Note warning when loading the page:
    Use of uninitialized value $uploadborrowers in concatenation (.) or string at /kohadevbox/koha/tools/import_borrowers.pl line 105.
4 - Upload a patron file, under: Preserve existing borrowers
    "If matching record is already in the borrowers table:" choose "Ignore..."
5 - Import the file
6 - Note an warning:
    Use of uninitialized value $update_dateexpiry in string eq at /kohadevbox/koha/tools/import_borrowers.pl line 113.
7 - Apply patch, restart all
8 - Reload the tool
9 - Note no warning
10 - Upload the file again, same settings
11 - Note no warning
12 - Sign off!

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Lucas Gass (lukeg) 2025-07-31 18:48:20 UTC
Nice work everyone!

Pushed to main for 25.11