To recreate: 1 - Tail the logs in a terminal: tail -f /var/log/koha/kohadev/*.log 2 - Browse to Tools->IMport patrons 3 - Note warning when loading the page: Use of uninitialized value $uploadborrowers in concatenation (.) or string at /kohadevbox/koha/tools/import_borrowers.pl line 105. 4 - Upload a patron file, under: Preserve existing borrowers "If matching record is already in the borrowers table:" choose "Ignore..." 5 - Import the file 6 - Note an warning: Use of uninitialized value $update_dateexpiry in string eq at /kohadevbox/koha/tools/import_borrowers.pl line 113.
Created attachment 184862 [details] [review] Bug 40549: Silence two warnings in patron import tool To test: 1 - Tail the logs in a terminal: tail -f /var/log/koha/kohadev/*.log 2 - Browse to Tools->IMport patrons 3 - Note warning when loading the page: Use of uninitialized value $uploadborrowers in concatenation (.) or string at /kohadevbox/koha/tools/import_borrowers.pl line 105. 4 - Upload a patron file, under: Preserve existing borrowers "If matching record is already in the borrowers table:" choose "Ignore..." 5 - Import the file 6 - Note an warning: Use of uninitialized value $update_dateexpiry in string eq at /kohadevbox/koha/tools/import_borrowers.pl line 113. 7 - Apply patch, restart all 8 - Reload the tool 9 - Note no warning 10 - Upload the file again, same settings 11 - Note no warning 12 - Sign off! Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Trivial, self SO, moving to QA
Created attachment 184885 [details] [review] Bug 40549: Silence two warnings in patron import tool To test: 1 - Tail the logs in a terminal: tail -f /var/log/koha/kohadev/*.log 2 - Browse to Tools->IMport patrons 3 - Note warning when loading the page: Use of uninitialized value $uploadborrowers in concatenation (.) or string at /kohadevbox/koha/tools/import_borrowers.pl line 105. 4 - Upload a patron file, under: Preserve existing borrowers "If matching record is already in the borrowers table:" choose "Ignore..." 5 - Import the file 6 - Note an warning: Use of uninitialized value $update_dateexpiry in string eq at /kohadevbox/koha/tools/import_borrowers.pl line 113. 7 - Apply patch, restart all 8 - Reload the tool 9 - Note no warning 10 - Upload the file again, same settings 11 - Note no warning 12 - Sign off! Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Nice work everyone! Pushed to main for 25.11