Bug 40709

Summary: Status filter will display in wrong column if item-level_itypes is set to bibliographic record
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: CirculationAssignee: Lucas Gass (lukeg) <lucas>
Status: Signed Off --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: emily.lamancusa, gmcharlt, kyle
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 40709: Fix offset for status column
Bug 40709: Use data-colname for adding filters
Bug 40709: Use data-colname for adding filters
Bug 40709: Use data-colname for adding filters

Description Lucas Gass (lukeg) 2025-08-26 19:38:58 UTC
To recreate:

1. Set the 'item-level_itypes' system preference to 'Bibliographic record'
2. Go to any record that contains items and look at the holdings table.
3. Click 'Show filters'.
4. Notice that the Status column doesn't appear to have a filter. 

The filter is one column off.
Comment 1 Lucas Gass (lukeg) 2025-08-26 20:05:41 UTC
Created attachment 185804 [details] [review]
Bug 40709: Fix offset for status column

To test:
1. Set the 'item-level_itypes' system preference to 'Bibliographic record'
2. Go to any record that contains items and look at the holdings table.
3. Click 'Show filters'.
4. Notice that the Status column doesn't appear to have a filter.
5. APPLY PATCH
6. Try again, the Status filter should appear correctly. Make sure all other filters appear correct.
7. Set 'item-level_itypes' back to 'specific item'.
8. Make sure the filter still appears correctly. Make sure all other filters appear correct.
Comment 2 Lucas Gass (lukeg) 2025-08-26 20:16:56 UTC
Hmm, I don't like this, it's too fragile. Maybe we can do something better with data-colname, since we already have that.
Comment 3 Lucas Gass (lukeg) 2025-08-26 20:18:51 UTC
Created attachment 185805 [details] [review]
Bug 40709: Use data-colname for adding filters

To test:
1. Set the 'item-level_itypes' system preference to 'Bibliographic record'
2. Go to any record that contains items and look at the holdings table.
3. Click 'Show filters'.
4. Notice that the Status column doesn't appear to have a filter.
5. APPLY PATCH
6. Try again, the Status filter should appear correctly. Make sure all other filters appear correct.
7. Set 'item-level_itypes' back to 'specific item'.
8. Make sure the filter still appears correctly. Make sure all other filters appear correct.
Comment 4 Lucas Gass (lukeg) 2025-08-26 20:20:36 UTC
Created attachment 185806 [details] [review]
Bug 40709: Use data-colname for adding filters

To test:
1. Set the 'item-level_itypes' system preference to 'Bibliographic record'
2. Go to any record that contains items and look at the holdings table.
3. Click 'Show filters'.
4. Notice that the Status column doesn't appear to have a filter.
5. APPLY PATCH
6. Try again, the Status filter should appear correctly. Make sure all other filters appear correct.
7. Set 'item-level_itypes' back to 'specific item'.
8. Make sure the filter still appears correctly. Make sure all other filters appear correct.
Comment 5 Emily Lamancusa (emlam) 2025-08-27 18:32:27 UTC
Created attachment 185844 [details] [review]
Bug 40709: Use data-colname for adding filters

To test:
1. Set the 'item-level_itypes' system preference to 'Bibliographic record'
2. Go to any record that contains items and look at the holdings table.
3. Click 'Show filters'.
4. Notice that the Status column doesn't appear to have a filter.
5. APPLY PATCH
6. Try again, the Status filter should appear correctly. Make sure all other filters appear correct.
7. Set 'item-level_itypes' back to 'specific item'.
8. Make sure the filter still appears correctly. Make sure all other filters appear correct.

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>