To recreate: 1. Set the 'item-level_itypes' system preference to 'Bibliographic record' 2. Go to any record that contains items and look at the holdings table. 3. Click 'Show filters'. 4. Notice that the Status column doesn't appear to have a filter. The filter is one column off.
Created attachment 185804 [details] [review] Bug 40709: Fix offset for status column To test: 1. Set the 'item-level_itypes' system preference to 'Bibliographic record' 2. Go to any record that contains items and look at the holdings table. 3. Click 'Show filters'. 4. Notice that the Status column doesn't appear to have a filter. 5. APPLY PATCH 6. Try again, the Status filter should appear correctly. Make sure all other filters appear correct. 7. Set 'item-level_itypes' back to 'specific item'. 8. Make sure the filter still appears correctly. Make sure all other filters appear correct.
Hmm, I don't like this, it's too fragile. Maybe we can do something better with data-colname, since we already have that.
Created attachment 185805 [details] [review] Bug 40709: Use data-colname for adding filters To test: 1. Set the 'item-level_itypes' system preference to 'Bibliographic record' 2. Go to any record that contains items and look at the holdings table. 3. Click 'Show filters'. 4. Notice that the Status column doesn't appear to have a filter. 5. APPLY PATCH 6. Try again, the Status filter should appear correctly. Make sure all other filters appear correct. 7. Set 'item-level_itypes' back to 'specific item'. 8. Make sure the filter still appears correctly. Make sure all other filters appear correct.
Created attachment 185806 [details] [review] Bug 40709: Use data-colname for adding filters To test: 1. Set the 'item-level_itypes' system preference to 'Bibliographic record' 2. Go to any record that contains items and look at the holdings table. 3. Click 'Show filters'. 4. Notice that the Status column doesn't appear to have a filter. 5. APPLY PATCH 6. Try again, the Status filter should appear correctly. Make sure all other filters appear correct. 7. Set 'item-level_itypes' back to 'specific item'. 8. Make sure the filter still appears correctly. Make sure all other filters appear correct.
Created attachment 185844 [details] [review] Bug 40709: Use data-colname for adding filters To test: 1. Set the 'item-level_itypes' system preference to 'Bibliographic record' 2. Go to any record that contains items and look at the holdings table. 3. Click 'Show filters'. 4. Notice that the Status column doesn't appear to have a filter. 5. APPLY PATCH 6. Try again, the Status filter should appear correctly. Make sure all other filters appear correct. 7. Set 'item-level_itypes' back to 'specific item'. 8. Make sure the filter still appears correctly. Make sure all other filters appear correct. Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>