See "Bug 36640: Fix itemsearch", there is a lot of duplicated code to build the select nodes. We should refactor and simplify this code. Same on the item list of the bib detail page.
Created attachment 184926 [details] [review] Bug 38311: Do not use ID for column filters
Created attachment 184927 [details] [review] Bug 38311: wip Vue
Created attachment 186209 [details] [review] Bug 38311: Add dropdown list to column filters linked to an AV - Vue components
This is ready for blocked by parent bugs.
This is ready but blocked by parent bugs.
Created attachment 187376 [details] [review] Bug 38311: Do not use ID for column filters
Created attachment 187377 [details] [review] Bug 38311: Add dropdown list to column filters linked to an AV - Vue components
This is now ready for testing.
This is an easy one, it removes a bad pattern and improves the readability of the code. Can we get a signoff please?
Created attachment 188314 [details] [review] Bug 38311: Add dropdown list to column filters linked to an AV - Vue components
Created attachment 188468 [details] [review] Bug 38311: Do not use ID for column filters Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 188469 [details] [review] Bug 38311: Add dropdown list to column filters linked to an AV - Vue components Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment on attachment 188468 [details] [review] Bug 38311: Do not use ID for column filters Review of attachment 188468 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt @@ +159,5 @@ > e['_str'] = e.branchname; > return e; > }); > let filters_options = { > + libraries: all_libraries, Are we missing a dataFilter in a column definition here?
Created attachment 188924 [details] [review] Bug 38311: Fix 'Bookings to collect'/pendingbookings it was missing the dataFilter. Also needs coded_values to work correctly (which needs to be defined outside of document.ready).
(In reply to Matt Blenkinsop from comment #13) > Comment on attachment 188468 [details] [review] [review] > Bug 38311: Do not use ID for column filters > > Review of attachment 188468 [details] [review] [review]: > ----------------------------------------------------------------- > > ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt > @@ +159,5 @@ > > e['_str'] = e.branchname; > > return e; > > }); > > let filters_options = { > > + libraries: all_libraries, > > Are we missing a dataFilter in a column definition here? Yes, good catch, thanks!
Created attachment 189184 [details] [review] Bug 38311: Do not use ID for column filters Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk>
Created attachment 189185 [details] [review] Bug 38311: Add dropdown list to column filters linked to an AV - Vue components Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk>
Created attachment 189186 [details] [review] Bug 38311: Fix 'Bookings to collect'/pendingbookings it was missing the dataFilter. Also needs coded_values to work correctly (which needs to be defined outside of document.ready). Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk>
Nice work everyone! Pushed to main for 25.11
Created attachment 190071 [details] [review] Bug 38311: Fix Selenium and Cypress tests .dt-select-filter does no longer exist Here we rely on DT's API to retrieve the correct visible column index. However we cannot for Selenium tests, not ideal but it fixes the failure.
follow-up pushed to main