Bug 38311 - DataTables - Simplify the building of the dropdown list filters
Summary: DataTables - Simplify the building of the dropdown list filters
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Jonathan Druart
QA Contact: Matt Blenkinsop
URL:
Keywords:
Depends on: 38201 40565 40709 36640
Blocks:
  Show dependency treegraph
 
Reported: 2024-10-31 13:54 UTC by Jonathan Druart
Modified: 2025-10-28 09:22 UTC (History)
5 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Crowdfunding goal: 0
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38311: Do not use ID for column filters (20.40 KB, patch)
2025-07-31 13:48 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38311: wip Vue (2.00 KB, patch)
2025-07-31 13:48 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38311: Add dropdown list to column filters linked to an AV - Vue components (9.04 KB, patch)
2025-09-05 14:25 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38311: Do not use ID for column filters (20.41 KB, patch)
2025-10-03 10:17 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38311: Add dropdown list to column filters linked to an AV - Vue components (9.03 KB, patch)
2025-10-03 10:17 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38311: Add dropdown list to column filters linked to an AV - Vue components (9.12 KB, patch)
2025-10-23 09:48 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38311: Do not use ID for column filters (20.45 KB, patch)
2025-10-27 11:00 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38311: Add dropdown list to column filters linked to an AV - Vue components (9.17 KB, patch)
2025-10-27 11:01 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-10-31 13:54:35 UTC
See "Bug 36640: Fix itemsearch", there is a lot of duplicated code to build the select nodes. We should refactor and simplify this code.

Same on the item list of the bib detail page.
Comment 1 Jonathan Druart 2025-07-31 13:48:03 UTC
Created attachment 184926 [details] [review]
Bug 38311: Do not use ID for column filters
Comment 2 Jonathan Druart 2025-07-31 13:48:05 UTC
Created attachment 184927 [details] [review]
Bug 38311: wip Vue
Comment 3 Jonathan Druart 2025-09-05 14:25:40 UTC
Created attachment 186209 [details] [review]
Bug 38311: Add dropdown list to column filters linked to an AV - Vue components
Comment 4 Jonathan Druart 2025-09-05 14:26:11 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2025-09-05 14:26:31 UTC
This is ready but blocked by parent bugs.
Comment 6 Jonathan Druart 2025-10-03 10:17:37 UTC
Created attachment 187376 [details] [review]
Bug 38311: Do not use ID for column filters
Comment 7 Jonathan Druart 2025-10-03 10:17:40 UTC
Created attachment 187377 [details] [review]
Bug 38311: Add dropdown list to column filters linked to an AV - Vue components
Comment 8 Jonathan Druart 2025-10-03 10:19:35 UTC
This is now ready for testing.
Comment 9 Jonathan Druart 2025-10-23 09:37:23 UTC
This is an easy one, it removes a bad pattern and improves the readability of the code. Can we get a signoff please?
Comment 10 Jonathan Druart 2025-10-23 09:48:56 UTC
Created attachment 188314 [details] [review]
Bug 38311: Add dropdown list to column filters linked to an AV - Vue components
Comment 11 Owen Leonard 2025-10-27 11:00:59 UTC
Created attachment 188468 [details] [review]
Bug 38311: Do not use ID for column filters

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 12 Owen Leonard 2025-10-27 11:01:02 UTC
Created attachment 188469 [details] [review]
Bug 38311: Add dropdown list to column filters linked to an AV - Vue components

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 13 Matt Blenkinsop 2025-10-28 09:22:37 UTC
Comment on attachment 188468 [details] [review]
Bug 38311: Do not use ID for column filters

Review of attachment 188468 [details] [review]:
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt
@@ +159,5 @@
>                  e['_str'] = e.branchname;
>                  return e;
>              });
>              let filters_options = {
> +                libraries: all_libraries,

Are we missing a dataFilter in a column definition here?