| Summary: | Loading spinner not removed because .cover-slider is now used instead of .cover-slides | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Hammat wele <hammat.wele> |
| Component: | OPAC | Assignee: | Hammat wele <hammat.wele> |
| Status: | Needs Signoff --- | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, philippe.blouin |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Attachments: |
Bug 40799: Loading spinner not removed because .cover-slider is now used instead of .cover-slides
Bug 40799: Loading spinner not removed because .cover-slider is now used instead of .cover-slides |
||
|
Description
Hammat wele
2025-09-12 12:10:31 UTC
Created attachment 186384 [details] [review] Bug 40799: Loading spinner not removed because .cover-slider is now used instead of .cover-slides After Bug 32642, the spinner on cover images is hidden by verify_cover_images() which removes the .cover-slides class from the cover container. However, Bug 33848 modified the SCSS so that the spinner is now triggered by .cover-slider instead of .cover-slides. As a result, the spinner is never removed, because verify_cover_images() only removes .cover-slides. Test plan 1- Follow the test plan from Bug 32642. ==> The spinner is displayed and never disappears. 2. Reload the page. ==> The spinner disappears once the cover image is loaded. Created attachment 186531 [details] [review] Bug 40799: Loading spinner not removed because .cover-slider is now used instead of .cover-slides After Bug 32642, the spinner on cover images is hidden by verify_cover_images() which removes the .cover-slides class from the cover container. However, Bug 33848 modified the SCSS so that the spinner is now triggered by .cover-slider instead of .cover-slides. As a result, the spinner is never removed, because verify_cover_images() only removes .cover-slides. Test plan 1- Follow the test plan from Bug 32642. ==> The spinner is displayed and never disappears. 2- Apply the patch 3- Reload the page. ==> The spinner disappears once the cover image is loaded. |