Bug 40799 - Loading spinner not removed because .cover-slider is now used instead of .cover-slides
Summary: Loading spinner not removed because .cover-slider is now used instead of .cov...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Hammat wele
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-09-12 12:10 UTC by Hammat wele
Modified: 2025-09-12 12:29 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 40799: Loading spinner not removed because .cover-slider is now used instead of .cover-slides (1.61 KB, patch)
2025-09-12 12:29 UTC, Hammat wele
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Hammat wele 2025-09-12 12:10:31 UTC
After Bug 32642, the spinner on cover images is hidden by verify_cover_images() which removes the .cover-slides class from the cover container.

However, Bug 33848 modified the SCSS so that the spinner is now triggered by .cover-slider instead of .cover-slides.

As a result, the spinner is never removed, because verify_cover_images() only removes .cover-slides.

Test plan

1- Follow the test plan from Bug 32642.
   ==> The spinner is displayed and never disappears.
Comment 1 Hammat wele 2025-09-12 12:29:18 UTC
Created attachment 186384 [details] [review]
Bug 40799: Loading spinner not removed because .cover-slider is now used instead of .cover-slides

After Bug 32642, the spinner on cover images is hidden by verify_cover_images() which removes the .cover-slides class from the cover container.

However, Bug 33848 modified the SCSS so that the spinner is now triggered by .cover-slider instead of .cover-slides.

As a result, the spinner is never removed, because verify_cover_images() only removes .cover-slides.

Test plan

1- Follow the test plan from Bug 32642.
   ==> The spinner is displayed and never disappears.
2. Reload the page.
==> The spinner disappears once the cover image is loaded.