|
Description
Laura Escamilla
2025-09-25 17:48:23 UTC
Created attachment 186928 [details] [review] Bug 40879: New syspref for enabling and disabling Cite in OPAC Created attachment 186929 [details] [review] Bug 40879: Added system preference to sysprefs.pl Created attachment 186930 [details] [review] Bug 40879: Added new OpacCiteModal system preference to the admin opac sysprefs Created attachment 186931 [details] [review] Bug 40879: Added syspref to catalog_cite.inc Created attachment 186932 [details] [review] Bug 40879: Added syspref to opac-detail-sidebar.inc 1. Apply the patch. Use updatedatabase and restart_all 2. Go to System Preferences and search for OpacCiteModal. It is currently set to Disable. 3. Go to the Opac and ensure that the Cite feature is not displaying in the detailed bibliographic record. 4. Now go to the System Preferences and Enable OpacCiteModal. 5. Go back to the Opac and ensure that the Cite feature is displaying correctly again in the detailed bibliographic record. Please also ensure that the Cite modal works as originally designed. 6. Sign off and have a great day! Created attachment 186933 [details] [review] Bug 40879: New OpacCiteModal system preference Created attachment 186935 [details] [review] Bug 40879: Added system preference to sysprefs.pl Created attachment 186936 [details] [review] Bug 40879: Added OpacCiteModal system preference Created attachment 186937 [details] [review] Bug 40879: Added syspref to catalog_cite.inc Created attachment 186938 [details] [review] Bug 40879: Added syspref to opac-detail-sidebar.inc 1. Apply the patch. Use updatedatabase and restart_all 2. Go to System Preferences and search for OpacCiteModal. It is currently set to Disable. 3. Go to the Opac and ensure that the Cite feature is not displaying in the detailed bibliographic record. 4. Now go to the System Preferences and Enable OpacCiteModal. 5. Go back to the Opac and ensure that the Cite feature is displaying correctly again in the detailed bibliographic record. Please also ensure that the Cite modal works as originally designed. 6. Sign off and have a great day! Created attachment 186939 [details] [review] Bug 40879: Added system preference to sysprefs.pl Created attachment 186940 [details] [review] Bug 40879: Added OpacCiteModal system preference Created attachment 186941 [details] [review] Bug 40879: Added new OpacCiteModal system preference to the admin opac sysprefs Created attachment 190032 [details] [review] Bug 40879: Added syspref to catalog_cite.inc Signed-off-by: David Nind <david@davidnind.com> Created attachment 190033 [details] [review] Bug 40879: Added syspref to opac-detail-sidebar.inc 1. Apply the patch. Use updatedatabase and restart_all 2. Go to System Preferences and search for OpacCiteModal. It is currently set to Disable. 3. Go to the Opac and ensure that the Cite feature is not displaying in the detailed bibliographic record. 4. Now go to the System Preferences and Enable OpacCiteModal. 5. Go back to the Opac and ensure that the Cite feature is displaying correctly again in the detailed bibliographic record. Please also ensure that the Cite modal works as originally designed. 6. Sign off and have a great day! Signed-off-by: David Nind <david@davidnind.com> Created attachment 190034 [details] [review] Bug 40879: Added system preference to sysprefs.pl Signed-off-by: David Nind <david@davidnind.com> Created attachment 190035 [details] [review] Bug 40879: Added OpacCiteModal system preference Signed-off-by: David Nind <david@davidnind.com> Created attachment 190036 [details] [review] Bug 40879: Added new OpacCiteModal system preference to the admin opac sysprefs Signed-off-by: David Nind <david@davidnind.com> This is nice enhancement. Testing notes (using KTD): 1. The Cite option is shown by default in the OPAC, which I think is the correct approach. As it is currently on by default (and no way to turn it off), the leaving it as shown is preferred, I think. (The test plan says it is not shown by deafult.) Other observations: 1. I think a better name for the system preference is OPACCite, rather than with 'Modal' (which is more a developer term), and put OPAC in capitals (we have a lot of inconsistency here though!). 2. Suggested options and description for the new system preference: [Show/Don't show] the cite option on OPAC bibliographic detail pages. (In reply to David Nind from comment #19) > This is nice enhancement. > > Testing notes (using KTD): > > 1. The Cite option is shown by default in the OPAC, which I think is the > correct approach. As it is currently on by default (and no way to turn it > off), the leaving it as shown is preferred, I think. (The test plan says it > is not shown by deafult.) > > Other observations: > > 1. I think a better name for the system preference is OPACCite, rather than > with 'Modal' (which is more a developer term), and put OPAC in capitals (we > have a lot of inconsistency here though!). > > 2. Suggested options and description for the new system preference: > [Show/Don't show] the cite option on OPAC bibliographic detail pages. The patch still applies and works. I second David's comments. Failing QA so we can get a follow-up with the suggested changes (sorry Laura!). I can try my hand at making a follow-up if necessary. Created attachment 190065 [details] [review] Bug 40879: follow-up (change OpacCiteModal to OPACCite) This patch addresses QA comments on the new system preference name and description. Crossing my fingers I didn't mess everything up with my yellow belt git-fu skillzzz. I tried to commit a follow up addressing David's comments. Created attachment 190087 [details] [review] Bug 40879: Added syspref to catalog_cite.inc Signed-off-by: David Nind <david@davidnind.com> Created attachment 190088 [details] [review] Bug 40879: Added syspref to opac-detail-sidebar.inc 1. Apply the patch. Use updatedatabase and restart_all 2. Go to System Preferences and search for OpacCiteModal. It is currently set to Disable. 3. Go to the Opac and ensure that the Cite feature is not displaying in the detailed bibliographic record. 4. Now go to the System Preferences and Enable OpacCiteModal. 5. Go back to the Opac and ensure that the Cite feature is displaying correctly again in the detailed bibliographic record. Please also ensure that the Cite modal works as originally designed. 6. Sign off and have a great day! Signed-off-by: David Nind <david@davidnind.com> Created attachment 190089 [details] [review] Bug 40879: Added system preference to sysprefs.pl Signed-off-by: David Nind <david@davidnind.com> Created attachment 190090 [details] [review] Bug 40879: Added OpacCiteModal system preference Signed-off-by: David Nind <david@davidnind.com> Created attachment 190091 [details] [review] Bug 40879: Added new OpacCiteModal system preference to the admin opac sysprefs Signed-off-by: David Nind <david@davidnind.com> Created attachment 190092 [details] [review] Bug 40879: follow-up (change OpacCiteModal to OPACCite) This patch addresses QA comments on the new system preference name and description. Signed-off-by: David Nind <david@davidnind.com> (In reply to Caroline Cyr La Rose from comment #22) > Crossing my fingers I didn't mess everything up with my yellow belt git-fu > skillzzz. I tried to commit a follow up addressing David's comments. Thanks Caroline! Everything seemed to work as expected - have added my sign-off. |