Summary: | When placing multiple holds at once the individual "Pickup location:" dropdowns do not update when changing the top level "Pickup at:" dropdown" | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Circulation | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | Passed QA --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | alex, anneli.osterman, Chip.Halvorsen, cj.lynce, dbarden, gmcharlt, jonathan.druart, kebliss, kkrueger, kyle, laura, tomascohen, trevor.diamond |
Version: | Main | Keywords: | regression |
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40931 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | Holds | |
Attachments: |
Bug 40899: Fix rendering of JSON in data-attribute with html filter
Bug 40899: Fix rendering of JSON in data-attribute with html filter Screenshot of Place holds modal Bug 40899: Fix rendering of JSON in data-attribute with html filter |
Description
Lucas Gass (lukeg)
2025-09-29 16:48:55 UTC
The rendered data-pickup-locations attribute does not look right. Created attachment 187102 [details] [review] Bug 40899: Fix rendering of JSON in data-attribute with html filter To test: 1. Place a hold on many items 2. Change the "Pickup at:" dropdown" to something else 3. Notice the "Pickup location:" dropdowns do not change with it 4. APPLY PATCH 5. Try steps 1 & 2 again. This time the dropdpwns should adjust accordingly Created attachment 187140 [details] [review] Bug 40899: Fix rendering of JSON in data-attribute with html filter To test: 1. Place a hold on many items 2. Change the "Pickup at:" dropdown" to something else 3. Notice the "Pickup location:" dropdowns do not change with it 4. APPLY PATCH 5. Try steps 1 & 2 again. This time the dropdpwns should adjust accordingly Signed-off-by: Chip Halvorsen <chip.halvorsen@westlakelibrary.org> The patch is functioning as intended. However, the Pickup locations that are filled for each hold are not readable. The column is too narrow so only the first letter or two displays. Created attachment 187141 [details]
Screenshot of Place holds modal
(In reply to Chip Halvorsen from comment #4) > The patch is functioning as intended. However, the Pickup locations that are > filled for each hold are not readable. The column is too narrow so only the > first letter or two displays. I submitted bug 40931 for this issue since it is a css template issue. What caused the regression? Created attachment 187453 [details] [review] Bug 40899: Fix rendering of JSON in data-attribute with html filter To test: 1. Place a hold on many items 2. Change the "Pickup at:" dropdown" to something else 3. Notice the "Pickup location:" dropdowns do not change with it 4. APPLY PATCH 5. Try steps 1 & 2 again. This time the dropdpwns should adjust accordingly Signed-off-by: Chip Halvorsen <chip.halvorsen@westlakelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |