To recreate: 1. Place a hold on many items 2. Change the "Pickup at:" dropdown" to something else 2. Notice the "Pickup location:" dropdowns do not change with it This is a regression.
The rendered data-pickup-locations attribute does not look right.
Created attachment 187102 [details] [review] Bug 40899: Fix rendering of JSON in data-attribute with html filter To test: 1. Place a hold on many items 2. Change the "Pickup at:" dropdown" to something else 3. Notice the "Pickup location:" dropdowns do not change with it 4. APPLY PATCH 5. Try steps 1 & 2 again. This time the dropdpwns should adjust accordingly
Created attachment 187140 [details] [review] Bug 40899: Fix rendering of JSON in data-attribute with html filter To test: 1. Place a hold on many items 2. Change the "Pickup at:" dropdown" to something else 3. Notice the "Pickup location:" dropdowns do not change with it 4. APPLY PATCH 5. Try steps 1 & 2 again. This time the dropdpwns should adjust accordingly Signed-off-by: Chip Halvorsen <chip.halvorsen@westlakelibrary.org>
The patch is functioning as intended. However, the Pickup locations that are filled for each hold are not readable. The column is too narrow so only the first letter or two displays.
Created attachment 187141 [details] Screenshot of Place holds modal
(In reply to Chip Halvorsen from comment #4) > The patch is functioning as intended. However, the Pickup locations that are > filled for each hold are not readable. The column is too narrow so only the > first letter or two displays. I submitted bug 40931 for this issue since it is a css template issue.
What caused the regression?
Created attachment 187453 [details] [review] Bug 40899: Fix rendering of JSON in data-attribute with html filter To test: 1. Place a hold on many items 2. Change the "Pickup at:" dropdown" to something else 3. Notice the "Pickup location:" dropdowns do not change with it 4. APPLY PATCH 5. Try steps 1 & 2 again. This time the dropdpwns should adjust accordingly Signed-off-by: Chip Halvorsen <chip.halvorsen@westlakelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to main for 25.11
We do have the jquery fix in place, but it would also be great to see this backported.
Nice work everyone! Pushed to 25.05.x
Pushed to 24.11.x for 24.11.11