Created attachment 187221 [details] Example of hold pickup locations dropdown issue When placing a patron hold on multiple items at the same time, the width of the pickup location drop-down boxes are not wide enough to fully display the name of the pickup location. For short location names, only one letter is show. (see screenshot) This appears to have been introduced by bug 39533 in koha-tmpl/intranet-tmpl/prog/css/select2.css - '.select2.select2-container.select2-container--default' is set at 60%.
I didn't see your comment and I reached the same conclusion: This is fixed if I remove the css changes from bug 39533 koha-tmpl/intranet-tmpl/prog/css/select2.css .select2.select2-container.select2-container--default { flex-grow: 1; max-width: 60%; } fieldset.rows .select2 li { clear: none; width: unset; }
Created attachment 187454 [details] [review] Bug 40931: (bug 39533 follow-up) Isolate CSS changes to prevent side-effects The changes made on bug 39533 for the export page have affected other instance of select2. eg. on the "place holds" view the select2 elements are too narrow. This patch suggests to isolate the CSS changes so they will only affect the export page. Test plan: Confirm that this patch does not affect the display of the select2 elements from the export page. Confirm that the pickup locations are wider (and their values are displayed) when placing multi holds
Unfortunately this change impacts other items: for example, the item edit page has select2 boxes that now different sizes (see screenshot). This actually breaks what was fixed in bug_40897 (technically it now makes the select2 boxes shorter than the flatpickr boxes, which is opposite the original problem on that big)
Created attachment 187551 [details] Example of item edit page select2 boxes after testing patch
Created attachment 187649 [details] [review] Bug 40931: (bug 39533 follow-up) More specific max-width CSS rule to prevent side-effects The changes made on bug 39533 for the export page have affected other instance of select2. eg. on the "place holds" view the select2 elements are too narrow. This patch suggests to reduce the elements on which the CSS rule 'max-width: 60%' is applied. Test plan: Confirm that this patch does not affect the display of the select2 elements on the export and item edition pages. Confirm that the pickup locations are wider (and their values are displayed) when placing multi holds
(In reply to CJ Lynce from comment #3) > Unfortunately this change impacts other items: for example, the item edit > page has select2 boxes that now different sizes (see screenshot). This > actually breaks what was fixed in bug_40897 (technically it now makes the > select2 boxes shorter than the flatpickr boxes, which is opposite the > original problem on that big) Good catch, thanks!
Created attachment 187708 [details] [review] Bug 40931: (bug 39533 follow-up) More specific max-width CSS rule to prevent side-effects The changes made on bug 39533 for the export page have affected other instance of select2. eg. on the "place holds" view the select2 elements are too narrow. This patch suggests to reduce the elements on which the CSS rule 'max-width: 60%' is applied. Test plan: Confirm that this patch does not affect the display of the select2 elements on the export and item edition pages. Confirm that the pickup locations are wider (and their values are displayed) when placing multi holds Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org>
This revised patch fixes the issue on the Multi-holds placement screen. It does not affect the select2 boxes on the item edit screen, and I checked a couple other places select2 is used, they are also unaffected. Thank you!
Created attachment 188025 [details] [review] Bug 40931: (bug 39533 follow-up) More specific max-width CSS rule to prevent side-effects The changes made on bug 39533 for the export page have affected other instance of select2. eg. on the "place holds" view the select2 elements are too narrow. This patch suggests to reduce the elements on which the CSS rule 'max-width: 60%' is applied. Test plan: Confirm that this patch does not affect the display of the select2 elements on the export and item edition pages. Confirm that the pickup locations are wider (and their values are displayed) when placing multi holds Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x
Depends on Bug 39533 not in 24.11.x