| Summary: | Fix translatability for "Add new" and "Remove this" in vue | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
| Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | Pushed to main --- | QA Contact: | Matt Blenkinsop <matt.blenkinsop> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | jonathan.druart, katrin.fischer, lucas, matt.blenkinsop |
| Version: | Main | Keywords: | rel_25_11_candidate, RM_priority |
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
25.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 38010, 38201 | ||
| Bug Blocks: | 41357 | ||
| Attachments: |
Bug 41088: (bug 38201 follow-up) Fix I18N for relationships
Bug 41088: (bug 38201 follow-up) Fix I18N for relationships Bug 41088: (bug 38201 follow-up) Fix I18N for relationships |
||
|
Description
Caroline Cyr La Rose
2025-10-23 14:26:41 UTC
I would have tried to add context, but it's in a widget by itself. I have updated the bug description, because adding context won't solve the problem here as in other spots. We need those to be separate strings. I am also pondering updating severity. * "new" would have to be changed depending on the word that follows in German too. It's neuer Provider, but neue Bibliothek etc. * There are language that need the adjective after the substantive. This way of coding doesn't allow to move the placeholder. For the translations it's almost always bad to put sentences together like this, splitting the strings. It almost always creates problems with translations for one language or the other. Please avoid. Same for "There are no %s created yet" Created attachment 189583 [details] [review] Bug 41088: (bug 38201 follow-up) Fix I18N for relationships "Add new x", "Remove this x" and "There are no x created yet" were not translatable correctly. Test plan: Add a new agreement, then a new title, and confirm that the 3 strings are correctly displayed. Then try to update .po files, translate the strings, and install the translations and confirm that the strings are correctly translated when using a translated interface. Thanks Joubu!
Just a note as I saw you removed these lines (which is good):
- namePlural: $__("licenses"),
This is bad because there are languages with more than one plural form depending on the number or if 0. Our translation tools can deal with it, but only if they are used :)
I can't get into my ktd while travelling - maybe someone would like to work on this with me? Created attachment 189896 [details] [review] Bug 41088: (bug 38201 follow-up) Fix I18N for relationships "Add new x", "Remove this x" and "There are no x created yet" were not translatable correctly. Test plan: Add a new agreement, then a new title, and confirm that the 3 strings are correctly displayed. Then try to update .po files, translate the strings, and install the translations and confirm that the strings are correctly translated when using a translated interface. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 189907 [details] [review] Bug 41088: (bug 38201 follow-up) Fix I18N for relationships "Add new x", "Remove this x" and "There are no x created yet" were not translatable correctly. Test plan: Add a new agreement, then a new title, and confirm that the 3 strings are correctly displayed. Then try to update .po files, translate the strings, and install the translations and confirm that the strings are correctly translated when using a translated interface. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> Nice work everyone! Pushed to main for 25.11 |