The "Add new %s" in the translation files for vue files is nice and reusable in English, but it doesn't work in French because the "new" word and the determinant will change depending on what the new thing is. In the new vendors page, there is - Add new alias - Add new contract - Add new interface These need all to be translated differently - Ajouter un nouvel alias (alias is masculine but start with a vowel, un nouvel) - Ajouter un nouveau contrat (contrat is masculine, un nouveau) - Ajouter une nouvelle interface (interface is feminine, une nouvelle) We need to have one string per new thing. I suspect it's the same for the "Remove this %s" string.
I would have tried to add context, but it's in a widget by itself.
I have updated the bug description, because adding context won't solve the problem here as in other spots. We need those to be separate strings. I am also pondering updating severity. * "new" would have to be changed depending on the word that follows in German too. It's neuer Provider, but neue Bibliothek etc. * There are language that need the adjective after the substantive. This way of coding doesn't allow to move the placeholder. For the translations it's almost always bad to put sentences together like this, splitting the strings. It almost always creates problems with translations for one language or the other. Please avoid.
Same for "There are no %s created yet"
Created attachment 189583 [details] [review] Bug 41088: (bug 38201 follow-up) Fix I18N for relationships "Add new x", "Remove this x" and "There are no x created yet" were not translatable correctly. Test plan: Add a new agreement, then a new title, and confirm that the 3 strings are correctly displayed. Then try to update .po files, translate the strings, and install the translations and confirm that the strings are correctly translated when using a translated interface.
Thanks Joubu! Just a note as I saw you removed these lines (which is good): - namePlural: $__("licenses"), This is bad because there are languages with more than one plural form depending on the number or if 0. Our translation tools can deal with it, but only if they are used :)
I can't get into my ktd while travelling - maybe someone would like to work on this with me?
Created attachment 189896 [details] [review] Bug 41088: (bug 38201 follow-up) Fix I18N for relationships "Add new x", "Remove this x" and "There are no x created yet" were not translatable correctly. Test plan: Add a new agreement, then a new title, and confirm that the 3 strings are correctly displayed. Then try to update .po files, translate the strings, and install the translations and confirm that the strings are correctly translated when using a translated interface. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 189907 [details] [review] Bug 41088: (bug 38201 follow-up) Fix I18N for relationships "Add new x", "Remove this x" and "There are no x created yet" were not translatable correctly. Test plan: Add a new agreement, then a new title, and confirm that the 3 strings are correctly displayed. Then try to update .po files, translate the strings, and install the translations and confirm that the strings are correctly translated when using a translated interface. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk>
Nice work everyone! Pushed to main for 25.11