Created attachment 188373 [details] [review] Bug 41090: Handle auto_renew_final message on renew.pl This patch removes the error and adds a variable mentioning the last renewal so we can note for the patron To test: 1 - Set a circ rule for: Renewals Allowed: 1 Renewal period: 5 No renewal before: 6 No automatic renewal before: 6 Auto renewal: Yes 2 - Issue an item that matches that rule 3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew 4 - Enter the item barcode 5 - You see 2 messages: Cannot renew: auto_renew_final "Continue without renewing" Item renewed.. 6 - Apply patch 7 - Check in item, and repeat 2-4 8 - Now you get a single success message and a note that this is the last renewal 9 - Sign off! Created attachment 190206 [details] [review] Bug 41090: Handle auto_unseen_final message on renew.pl To test: 0 - Follow previous plan, set system preference UnseenRenewals to 'Allow' 1 - Adjust circ rule for: Renewals Allowed: 2 Unseen renewals allowed: 1 Renewal period: 5 No renewal before: 6 No automatic renewal before: 6 Auto renewal: Yes 2 - Issue an item that matches that rule 3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew 4 - Enter the item barcode 5 - You see 2 messages: Cannot renew: auto_unseen_final "Continue without renewing" Item renewed.. 6 - Apply patch 7 - Check in item, and repeat 2-4 8 - Now you get a single success message and a note that this is the last unseen renewal 9 - Sign off! Created attachment 190207 [details] [review] Bug 41090: Handle auto_unseen_final message on renew.pl To test: 0 - Follow previous plan, set system preference UnseenRenewals to 'Allow' 1 - Adjust circ rule for: Renewals Allowed: 3 Unseen renewals allowed: 2 Renewal period: 5 No renewal before: 6 No automatic renewal before: 6 Auto renewal: Yes 2 - Issue an item that matches that rule 3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew 4 - Enter the item barcode 5 - You see 2 messages: Cannot renew: Item has been scheduled for automatic renewal "Continue without renewing" Item renewed.. 6 - Apply patch 7 - Check in item, and repeat 2-4 8 - Now you get a single success message and a note that the item has been renewed Created attachment 190208 [details] [review] Bug 41090: Handle auto_renew message on renew.pl This message can be ignored, we were allowed to renew in this case To test: 0 - Follow previous plan, set system preference UnseenRenewals to 'Allow' 1 - Adjust circ rule for: Renewals Allowed: 3 Unseen renewals allowed: 2 Renewal period: 5 No renewal before: 6 No automatic renewal before: 6 Auto renewal: Yes 2 - Issue an item that matches that rule 3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew 4 - Enter the item barcode 5 - You see 2 messages: Cannot renew: Item has been scheduled for automatic renewal "Continue without renewing" Item renewed.. 6 - Apply patch 7 - Check in item, and repeat 2-4 8 - Now you get a single success message and a note that the item has been renewed Created attachment 190209 [details] [review] Bug 41090: Handle auto_renew_final message on renew.pl This patch removes the error and adds a variable mentioning the last renewal so we can note for the patron To test: 1 - Set a circ rule for: Renewals Allowed: 1 Renewal period: 5 No renewal before: 6 No automatic renewal before: 6 Auto renewal: Yes 2 - Issue an item that matches that rule 3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew 4 - Enter the item barcode 5 - You see 2 messages: Cannot renew: auto_renew_final "Continue without renewing" Item renewed.. 6 - Apply patch 7 - Check in item, and repeat 2-4 8 - Now you get a single success message and a note that this is the last renewal 9 - Sign off! Created attachment 190210 [details] [review] Bug 41090: Handle auto_unseen_final message on renew.pl To test: 0 - Follow previous plan, set system preference UnseenRenewals to 'Allow' 1 - Adjust circ rule for: Renewals Allowed: 2 Unseen renewals allowed: 1 Renewal period: 5 No renewal before: 6 No automatic renewal before: 6 Auto renewal: Yes 2 - Issue an item that matches that rule 3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew 4 - Enter the item barcode 5 - You see 2 messages: Cannot renew: auto_unseen_final "Continue without renewing" Item renewed.. 6 - Apply patch 7 - Check in item, and repeat 2-4 8 - Now you get a single success message and a note that this is the last unseen renewal 9 - Sign off! Created attachment 190211 [details] [review] Bug 41090: Handle auto_renew message on renew.pl This message can be ignored, we were allowed to renew in this case To test: 0 - Follow previous plan, set system preference UnseenRenewals to 'Allow' 1 - Adjust circ rule for: Renewals Allowed: 3 Unseen renewals allowed: 2 Renewal period: 5 No renewal before: 6 No automatic renewal before: 6 Auto renewal: Yes 2 - Issue an item that matches that rule 3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew 4 - Enter the item barcode 5 - You see 2 messages: Cannot renew: Item has been scheduled for automatic renewal "Continue without renewing" Item renewed.. 6 - Apply patch 7 - Check in item, and repeat 2-4 8 - Now you get a single success message and a note that the item has been renewed Created attachment 190488 [details] [review] Bug 41090: Handle auto_renew_final message on renew.pl This patch removes the error and adds a variable mentioning the last renewal so we can note for the patron To test: 1 - Set a circ rule for: Renewals Allowed: 1 Renewal period: 5 No renewal before: 6 No automatic renewal before: 6 Auto renewal: Yes 2 - Issue an item that matches that rule 3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew 4 - Enter the item barcode 5 - You see 2 messages: Cannot renew: auto_renew_final "Continue without renewing" Item renewed.. 6 - Apply patch 7 - Check in item, and repeat 2-4 8 - Now you get a single success message and a note that this is the last renewal 9 - Sign off! Signed-off-by: David Nind <david@davidnind.com> Created attachment 190489 [details] [review] Bug 41090: Handle auto_unseen_final message on renew.pl To test: 0 - Follow previous plan, set system preference UnseenRenewals to 'Allow' 1 - Adjust circ rule for: Renewals Allowed: 2 Unseen renewals allowed: 1 Renewal period: 5 No renewal before: 6 No automatic renewal before: 6 Auto renewal: Yes 2 - Issue an item that matches that rule 3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew 4 - Enter the item barcode 5 - You see 2 messages: Cannot renew: auto_unseen_final "Continue without renewing" Item renewed.. 6 - Apply patch 7 - Check in item, and repeat 2-4 8 - Now you get a single success message and a note that this is the last unseen renewal 9 - Sign off! Signed-off-by: David Nind <david@davidnind.com> Created attachment 190490 [details] [review] Bug 41090: Handle auto_renew message on renew.pl This message can be ignored, we were allowed to renew in this case To test: 0 - Follow previous plan, set system preference UnseenRenewals to 'Allow' 1 - Adjust circ rule for: Renewals Allowed: 3 Unseen renewals allowed: 2 Renewal period: 5 No renewal before: 6 No automatic renewal before: 6 Auto renewal: Yes 2 - Issue an item that matches that rule 3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew 4 - Enter the item barcode 5 - You see 2 messages: Cannot renew: Item has been scheduled for automatic renewal "Continue without renewing" Item renewed.. 6 - Apply patch 7 - Check in item, and repeat 2-4 8 - Now you get a single success message and a note that the item has been renewed Signed-off-by: David Nind <david@davidnind.com> |
To recreate: 1 - Set a circ rule for: Renewals Allowed: 1 Renewal period: 5 No renewal before: 6 No automatic renewal before: 6 Auto renewal: Yes 2 - Issue an item that matches that rule 3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew 4 - Enter the item barcode 5 - You see 2 messages: Cannot renew: auto_renew_final "Continue without renewing" Item renewed..