| Summary: | Final auto renewal error not handled in renew.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Circulation | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | Needs Signoff --- | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gmcharlt, kyle, Laura.escamilla |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Attachments: | Bug 41090: Handle auto_renew_final message on renew.pl | ||
Created attachment 188373 [details] [review] Bug 41090: Handle auto_renew_final message on renew.pl This patch removes the error and adds a variable mentioning the last renewal so we can note for the patron To test: 1 - Set a circ rule for: Renewals Allowed: 1 Renewal period: 5 No renewal before: 6 No automatic renewal before: 6 Auto renewal: Yes 2 - Issue an item that matches that rule 3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew 4 - Enter the item barcode 5 - You see 2 messages: Cannot renew: auto_renew_final "Continue without renewing" Item renewed.. 6 - Apply patch 7 - Check in item, and repeat 2-4 8 - Now you get a single success message and a note that this is the last renewal 9 - Sign off! |
To recreate: 1 - Set a circ rule for: Renewals Allowed: 1 Renewal period: 5 No renewal before: 6 No automatic renewal before: 6 Auto renewal: Yes 2 - Issue an item that matches that rule 3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew 4 - Enter the item barcode 5 - You see 2 messages: Cannot renew: auto_renew_final "Continue without renewing" Item renewed..