Bug 41090 - Final auto renewal error not handled in renew.pl
Summary: Final auto renewal error not handled in renew.pl
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Nick Clemens (kidclamp)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-10-23 15:46 UTC by Nick Clemens (kidclamp)
Modified: 2025-12-14 01:04 UTC (History)
3 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 41090: Handle auto_renew_final message on renew.pl (3.29 KB, patch)
2025-10-23 15:49 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 41090: Handle auto_unseen_final message on renew.pl (3.01 KB, patch)
2025-12-05 13:47 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 41090: Handle auto_unseen_final message on renew.pl (1.73 KB, patch)
2025-12-05 13:57 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 41090: Handle auto_renew message on renew.pl (1.79 KB, patch)
2025-12-05 13:58 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 41090: Handle auto_renew_final message on renew.pl (3.29 KB, patch)
2025-12-05 13:58 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 41090: Handle auto_unseen_final message on renew.pl (3.01 KB, patch)
2025-12-05 13:58 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 41090: Handle auto_renew message on renew.pl (1.79 KB, patch)
2025-12-05 13:58 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 41090: Handle auto_renew_final message on renew.pl (3.34 KB, patch)
2025-12-14 01:04 UTC, David Nind
Details | Diff | Splinter Review
Bug 41090: Handle auto_unseen_final message on renew.pl (3.05 KB, patch)
2025-12-14 01:04 UTC, David Nind
Details | Diff | Splinter Review
Bug 41090: Handle auto_renew message on renew.pl (1.84 KB, patch)
2025-12-14 01:04 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2025-10-23 15:46:40 UTC
To recreate:
1 - Set a circ rule for:
    Renewals Allowed: 1
    Renewal period: 5
    No renewal before: 6
    No automatic renewal before: 6
    Auto renewal: Yes
2 - Issue an item that matches that rule
3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew
4 - Enter the item barcode
5 - You see 2 messages:
    Cannot renew: auto_renew_final "Continue without renewing"
    Item renewed..
Comment 1 Nick Clemens (kidclamp) 2025-10-23 15:49:03 UTC Comment hidden (obsolete)
Comment 2 Nick Clemens (kidclamp) 2025-12-05 13:47:24 UTC Comment hidden (obsolete)
Comment 3 Nick Clemens (kidclamp) 2025-12-05 13:57:31 UTC Comment hidden (obsolete)
Comment 4 Nick Clemens (kidclamp) 2025-12-05 13:58:37 UTC Comment hidden (obsolete)
Comment 5 Nick Clemens (kidclamp) 2025-12-05 13:58:53 UTC
Created attachment 190209 [details] [review]
Bug 41090: Handle auto_renew_final message on renew.pl

This patch removes the error and adds a variable mentioning the last renewal so we can note for the patron

To test:
1 - Set a circ rule for:
    Renewals Allowed: 1
    Renewal period: 5
    No renewal before: 6
    No automatic renewal before: 6
    Auto renewal: Yes
2 - Issue an item that matches that rule
3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew
4 - Enter the item barcode
5 - You see 2 messages:
    Cannot renew: auto_renew_final "Continue without renewing"
    Item renewed..
6 - Apply patch
7 - Check in item, and repeat 2-4
8 - Now you get a single success message and a note that this is the last renewal
9 - Sign off!
Comment 6 Nick Clemens (kidclamp) 2025-12-05 13:58:56 UTC
Created attachment 190210 [details] [review]
Bug 41090: Handle auto_unseen_final message on renew.pl

To test:
0 - Follow previous plan, set system preference UnseenRenewals to 'Allow'
1 - Adjust circ rule for:
    Renewals Allowed: 2
    Unseen renewals allowed: 1
    Renewal period: 5
    No renewal before: 6
    No automatic renewal before: 6
    Auto renewal: Yes
2 - Issue an item that matches that rule
3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew
4 - Enter the item barcode
5 - You see 2 messages:
    Cannot renew: auto_unseen_final "Continue without renewing"
    Item renewed..
6 - Apply patch
7 - Check in item, and repeat 2-4
8 - Now you get a single success message and a note that this is the last unseen renewal
9 - Sign off!
Comment 7 Nick Clemens (kidclamp) 2025-12-05 13:58:59 UTC
Created attachment 190211 [details] [review]
Bug 41090: Handle auto_renew message on renew.pl

This message can be ignored, we were allowed to renew in this case

To test:
0 - Follow previous plan, set system preference UnseenRenewals to 'Allow'
1 - Adjust circ rule for:
    Renewals Allowed: 3
    Unseen renewals allowed: 2
    Renewal period: 5
    No renewal before: 6
    No automatic renewal before: 6
    Auto renewal: Yes
2 - Issue an item that matches that rule
3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew
4 - Enter the item barcode
5 - You see 2 messages:
    Cannot renew: Item has been scheduled for automatic renewal "Continue without renewing"
    Item renewed..
6 - Apply patch
7 - Check in item, and repeat 2-4
8 - Now you get a single success message and a note that the item has been renewed
Comment 8 David Nind 2025-12-14 01:04:08 UTC
Created attachment 190488 [details] [review]
Bug 41090: Handle auto_renew_final message on renew.pl

This patch removes the error and adds a variable mentioning the last renewal so we can note for the patron

To test:
1 - Set a circ rule for:
    Renewals Allowed: 1
    Renewal period: 5
    No renewal before: 6
    No automatic renewal before: 6
    Auto renewal: Yes
2 - Issue an item that matches that rule
3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew
4 - Enter the item barcode
5 - You see 2 messages:
    Cannot renew: auto_renew_final "Continue without renewing"
    Item renewed..
6 - Apply patch
7 - Check in item, and repeat 2-4
8 - Now you get a single success message and a note that this is the last renewal
9 - Sign off!

Signed-off-by: David Nind <david@davidnind.com>
Comment 9 David Nind 2025-12-14 01:04:11 UTC
Created attachment 190489 [details] [review]
Bug 41090: Handle auto_unseen_final message on renew.pl

To test:
0 - Follow previous plan, set system preference UnseenRenewals to 'Allow'
1 - Adjust circ rule for:
    Renewals Allowed: 2
    Unseen renewals allowed: 1
    Renewal period: 5
    No renewal before: 6
    No automatic renewal before: 6
    Auto renewal: Yes
2 - Issue an item that matches that rule
3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew
4 - Enter the item barcode
5 - You see 2 messages:
    Cannot renew: auto_unseen_final "Continue without renewing"
    Item renewed..
6 - Apply patch
7 - Check in item, and repeat 2-4
8 - Now you get a single success message and a note that this is the last unseen renewal
9 - Sign off!

Signed-off-by: David Nind <david@davidnind.com>
Comment 10 David Nind 2025-12-14 01:04:15 UTC
Created attachment 190490 [details] [review]
Bug 41090: Handle auto_renew message on renew.pl

This message can be ignored, we were allowed to renew in this case

To test:
0 - Follow previous plan, set system preference UnseenRenewals to 'Allow'
1 - Adjust circ rule for:
    Renewals Allowed: 3
    Unseen renewals allowed: 2
    Renewal period: 5
    No renewal before: 6
    No automatic renewal before: 6
    Auto renewal: Yes
2 - Issue an item that matches that rule
3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew
4 - Enter the item barcode
5 - You see 2 messages:
    Cannot renew: Item has been scheduled for automatic renewal "Continue without renewing"
    Item renewed..
6 - Apply patch
7 - Check in item, and repeat 2-4
8 - Now you get a single success message and a note that the item has been renewed

Signed-off-by: David Nind <david@davidnind.com>