| Summary: | Cannot cancel patron holds in some cases | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Circulation | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | cj.lynce, gmcharlt, kyle |
| Version: | Main | Keywords: | rel_25_11_candidate |
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 41211: Deal with findborrower in holds_table_patron_page function
Bug 41211: Deal with findborrower in holds_table_patron_page function |
||
|
Description
Lucas Gass (lukeg)
2025-11-06 21:13:27 UTC
Created attachment 189231 [details] [review] Bug 41211: Deal with findborrower in holds_table_patron_page function To test: 1. Find a patron, take note of their cardnumber, and place some holds for that patron. I use Ronnie Ballard ( 23529000139858 ) in k-t-d. 2. Scan the patrons cardnumber to bring you directly to their record. The URL for me is KOHA/cgi-bin/koha/circ/circulation.pl?findborrower=23529000139858 3. Go to the patron's "Hold" tab, check at least 1 hold and click "Cancel selected". 4. Nothing happens. Console error: Uncaught ReferenceError: biblionumbers is not defined 5. Try using the red trash can icon to delete the hold. A modal pops up, click "Confirm cancellation". 6. You are redirected to KOHA/cgi-bin/koha/circ/circulation.pl?borrowernumber= 7. IF you go back to the patron record the hold is not cancelled. 8. APPLY PATCH and clear the browser cache. 9. Try again, eveything should work! Created attachment 189365 [details] [review] Bug 41211: Deal with findborrower in holds_table_patron_page function To test: 1. Find a patron, take note of their cardnumber, and place some holds for that patron. I use Ronnie Ballard ( 23529000139858 ) in k-t-d. 2. Scan the patrons cardnumber to bring you directly to their record. The URL for me is KOHA/cgi-bin/koha/circ/circulation.pl?findborrower=23529000139858 3. Go to the patron's "Hold" tab, check at least 1 hold and click "Cancel selected". 4. Nothing happens. Console error: Uncaught ReferenceError: biblionumbers is not defined 5. Try using the red trash can icon to delete the hold. A modal pops up, click "Confirm cancellation". 6. You are redirected to KOHA/cgi-bin/koha/circ/circulation.pl?borrowernumber= 7. IF you go back to the patron record the hold is not cancelled. 8. APPLY PATCH and clear the browser cache. 9. Try again, eveything should work! Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> Patch works as described, canceling works again when pulling up patron record with findborrower. |