Bug 41211 - Cannot cancel patron holds in some cases
Summary: Cannot cancel patron holds in some cases
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords: rel_25_11_candidate
Depends on:
Blocks:
 
Reported: 2025-11-06 21:13 UTC by Lucas Gass (lukeg)
Modified: 2025-11-07 17:27 UTC (History)
3 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 41211: Deal with findborrower in holds_table_patron_page function (1.89 KB, patch)
2025-11-06 21:28 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 41211: Deal with findborrower in holds_table_patron_page function (1.94 KB, patch)
2025-11-07 17:26 UTC, CJ Lynce
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2025-11-06 21:13:27 UTC
The workflow here is specific.

To recreate:

1. Find a patron, take note of their cardnumber, and place some holds for that patron. I use Ronnie Ballard ( 23529000139858 ) in k-t-d.

2. Scan the patrons cardnumber to bring you directly to their record. The URL for me is KOHA/cgi-bin/koha/circ/circulation.pl?findborrower=23529000139858

3. Go to the patron's "Hold" tab, check at least 1 hold and click "Cancel selected".

4. Nothing happens. Console error: Uncaught ReferenceError: biblionumbers is not defined 

5. Try using the red trash can icon to delete the hold. A modal pops up, click "Confirm cancellation".

6. You are redirected to KOHA/cgi-bin/koha/circ/circulation.pl?borrowernumber=

7. IF you go back to the patron record the hold is not cancelled.
Comment 1 Lucas Gass (lukeg) 2025-11-06 21:28:12 UTC
Created attachment 189231 [details] [review]
Bug 41211: Deal with findborrower in holds_table_patron_page function

To test:

1. Find a patron, take note of their cardnumber, and place some holds for that patron. I use Ronnie Ballard ( 23529000139858 ) in k-t-d.
2. Scan the patrons cardnumber to bring you directly to their record. The URL for me is KOHA/cgi-bin/koha/circ/circulation.pl?findborrower=23529000139858
3. Go to the patron's "Hold" tab, check at least 1 hold and click "Cancel selected".
4. Nothing happens. Console error: Uncaught ReferenceError: biblionumbers is not defined
5. Try using the red trash can icon to delete the hold. A modal pops up, click "Confirm cancellation".
6. You are redirected to KOHA/cgi-bin/koha/circ/circulation.pl?borrowernumber=
7. IF you go back to the patron record the hold is not cancelled.
8. APPLY PATCH and clear the browser cache.
9. Try again, eveything should work!
Comment 2 CJ Lynce 2025-11-07 17:26:03 UTC
Created attachment 189365 [details] [review]
Bug 41211: Deal with findborrower in holds_table_patron_page function

To test:

1. Find a patron, take note of their cardnumber, and place some holds for that patron. I use Ronnie Ballard ( 23529000139858 ) in k-t-d.
2. Scan the patrons cardnumber to bring you directly to their record. The URL for me is KOHA/cgi-bin/koha/circ/circulation.pl?findborrower=23529000139858
3. Go to the patron's "Hold" tab, check at least 1 hold and click "Cancel selected".
4. Nothing happens. Console error: Uncaught ReferenceError: biblionumbers is not defined
5. Try using the red trash can icon to delete the hold. A modal pops up, click "Confirm cancellation".
6. You are redirected to KOHA/cgi-bin/koha/circ/circulation.pl?borrowernumber=
7. IF you go back to the patron record the hold is not cancelled.
8. APPLY PATCH and clear the browser cache.
9. Try again, eveything should work!

Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org>
Comment 3 CJ Lynce 2025-11-07 17:27:18 UTC
Patch works as described, canceling works again when pulling up patron record with findborrower.