| Summary: | Regression: Clicking the 'Ignore' button on hold found modal for already-waiting hold does not dismiss the modal (again) | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
| Component: | Circulation | Assignee: | Andrew Fuerste-Henry <andrew> |
| Status: | Pushed to stable --- | QA Contact: | Lucas Gass (lukeg) <lucas> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | david, gmcharlt, jacob.omara, kebliss, kyle, lucas, nick |
| Version: | Main | Keywords: | rel_25_05_candidate, rel_25_11_candidate |
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39108 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes a regression when checking in an item. Clicking the "Ignore" option in the dialog box, when an item already has a waiting status, just reloaded the dialog box. Clicking the "Ignore" option now closes the dialog box and works as expected.
|
Version(s) released in: |
26.05.00,25.11.01
|
| Circulation function: | |||
| Bug Depends on: | 34596 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 41345: Restore ignore button functionality
Bug 41345: Restore ignore button functionality Bug 41345: Restore ignore button functionality |
||
|
Description
Andrew Fuerste-Henry
2025-12-01 23:41:04 UTC
Created attachment 190066 [details] [review] Bug 41345: Restore ignore button functionality To test: 1 - place a hold 2 - check an item in to fill your hold, confirm so item goes to Waiting status 3 - check item in again, get Hold Already Waiting modal 4 - clck Ignore, confirm modal reloads immediately 5 - apply patch, restart_all 6 - reload checkin page 7 - check item in again, get Hold Already Waiting modal 8 - click Ignore, confirm modal goes away and doesn't return Created attachment 190138 [details] [review] Bug 41345: Restore ignore button functionality To test: 1 - place a hold 2 - check an item in to fill your hold, confirm so item goes to Waiting status 3 - check item in again, get Hold Already Waiting modal 4 - clck Ignore, confirm modal reloads immediately 5 - apply patch, restart_all 6 - reload checkin page 7 - check item in again, get Hold Already Waiting modal 8 - click Ignore, confirm modal goes away and doesn't return Signed-off-by: David Nind <david@davidnind.com> Created attachment 190593 [details] [review] Bug 41345: Restore ignore button functionality To test: 1 - place a hold 2 - check an item in to fill your hold, confirm so item goes to Waiting status 3 - check item in again, get Hold Already Waiting modal 4 - clck Ignore, confirm modal reloads immediately 5 - apply patch, restart_all 6 - reload checkin page 7 - check item in again, get Hold Already Waiting modal 8 - click Ignore, confirm modal goes away and doesn't return Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Nice work everyone! Pushed to main for 26.05 Thanks all, pushed to 25.11.x Thanks all, pushed to 25.11.x |