| Summary: | Error when loading "Record sources" Vue app | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | Pushed to main --- | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Severity: | blocker | ||
| Priority: | P5 - low | CC: | david, lucas, matt.blenkinsop, tomascohen |
| Version: | unspecified | Keywords: | rel_25_11_candidate |
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
25.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 41336, 41355 | ||
| Attachments: |
Bug 41354: Fix record sources Vue app
Bug 41354: Fix record sources Vue app Bug 41354: Fix record sources Vue app |
||
|
Description
Jonathan Druart
2025-12-02 13:02:09 UTC
Created attachment 190078 [details] [review] Bug 41354: Fix record sources Vue app It fixes a JS error in the console Uncaught (in promise) TypeError: can't convert undefined to object Also fixes the cypress tests: t/cypress/integration/Admin/RecordSources_spec.ts Test plan: Create a new record source Note that there is still a cypress failure actually. What broke this? (In reply to Tomás Cohen Arazi (tcohen) from comment #3) > What broke this? I don't know. Bug 38201 or node upgrade, or something else. Created attachment 190093 [details] [review] Bug 41354: Fix record sources Vue app It fixes a JS error in the console Uncaught (in promise) TypeError: can't convert undefined to object Also fixes the cypress tests: t/cypress/integration/Admin/RecordSources_spec.ts Test plan: Create a new record source Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. The tests now pass: yarn cypress run --spec t/cypress/integration/Admin/RecordSources_spec.ts 2. Note: There are no sidebar menu items when in record sources (Administration > Catalog > Record sources). Created attachment 190104 [details] [review] Bug 41354: Fix record sources Vue app It fixes a JS error in the console Uncaught (in promise) TypeError: can't convert undefined to object Also fixes the cypress tests: t/cypress/integration/Admin/RecordSources_spec.ts Test plan: Create a new record source Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Changes make sense, QA script happy. Functionality is back (rendering the table when record sources are defined) and tests pass. Thanks Jonathan (In reply to David Nind from comment #6) > Testing notes (using KTD): > > 1. The tests now pass: yarn cypress run --spec > t/cypress/integration/Admin/RecordSources_spec.ts I use `run_cypress --spec t/cypress/integration/Admin/RecordSources_spec.ts` Nice work everyone! Pushed to main for 25.11 |