Bug 41354 - Error when loading "Record sources" Vue app
Summary: Error when loading "Record sources" Vue app
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low blocker
Assignee: Jonathan Druart
QA Contact: Tomás Cohen Arazi (tcohen)
URL:
Keywords: rel_25_11_candidate
Depends on:
Blocks: 41336 41355
  Show dependency treegraph
 
Reported: 2025-12-02 13:02 UTC by Jonathan Druart
Modified: 2025-12-03 15:29 UTC (History)
4 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 41354: Fix record sources Vue app (1.43 KB, patch)
2025-12-02 13:04 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41354: Fix record sources Vue app (1.48 KB, patch)
2025-12-02 19:22 UTC, David Nind
Details | Diff | Splinter Review
Bug 41354: Fix record sources Vue app (1.64 KB, patch)
2025-12-03 11:35 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-12-02 13:02:09 UTC
Uncaught (in promise) TypeError: can't convert undefined to object
Comment 1 Jonathan Druart 2025-12-02 13:04:05 UTC
Created attachment 190078 [details] [review]
Bug 41354: Fix record sources Vue app

It fixes a JS error in the console
Uncaught (in promise) TypeError: can't convert undefined to object

Also fixes the cypress tests:
t/cypress/integration/Admin/RecordSources_spec.ts

Test plan:
Create a new record source
Comment 2 Jonathan Druart 2025-12-02 13:04:25 UTC
Note that there is still a cypress failure actually.
Comment 3 Tomás Cohen Arazi (tcohen) 2025-12-02 13:17:00 UTC
What broke this?
Comment 4 Jonathan Druart 2025-12-02 13:25:33 UTC
(In reply to Tomás Cohen Arazi (tcohen) from comment #3)
> What broke this?

I don't know. Bug 38201 or node upgrade, or something else.
Comment 5 David Nind 2025-12-02 19:22:48 UTC
Created attachment 190093 [details] [review]
Bug 41354: Fix record sources Vue app

It fixes a JS error in the console
Uncaught (in promise) TypeError: can't convert undefined to object

Also fixes the cypress tests:
t/cypress/integration/Admin/RecordSources_spec.ts

Test plan:
Create a new record source

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2025-12-02 19:23:08 UTC
Testing notes (using KTD):

1. The tests now pass: yarn cypress run --spec t/cypress/integration/Admin/RecordSources_spec.ts

2. Note: There are no sidebar menu items when in record sources (Administration > Catalog > Record sources).
Comment 7 Tomás Cohen Arazi (tcohen) 2025-12-03 11:35:35 UTC
Created attachment 190104 [details] [review]
Bug 41354: Fix record sources Vue app

It fixes a JS error in the console
Uncaught (in promise) TypeError: can't convert undefined to object

Also fixes the cypress tests:
t/cypress/integration/Admin/RecordSources_spec.ts

Test plan:
Create a new record source

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 8 Tomás Cohen Arazi (tcohen) 2025-12-03 11:37:44 UTC
Changes make sense, QA script happy. Functionality is back (rendering the table when record sources are defined) and tests pass.

Thanks Jonathan

(In reply to David Nind from comment #6)
> Testing notes (using KTD):
> 
> 1. The tests now pass: yarn cypress run --spec
> t/cypress/integration/Admin/RecordSources_spec.ts

I use `run_cypress --spec t/cypress/integration/Admin/RecordSources_spec.ts`
Comment 9 Lucas Gass (lukeg) 2025-12-03 15:29:04 UTC
Nice work everyone!

Pushed to main for 25.11