Bug 41563

Summary: Tidy kohaTable block - acqui
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: TemplatesAssignee: Jonathan Druart <jonathan.druart>
Status: Pushed to main --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: lucas
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: Medium patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
26.05.00
Circulation function:
Bug Depends on: 39715, 41562    
Bug Blocks: 41324, 41807, 41848    
Attachments: Bug 41563: Tidy kohaTable - acqui/acqui-home.tt
Bug 41563: Tidy kohaTable - acqui/basket.tt
Bug 41563: Tidy kohaTable - acqui/basketgroup.tt
Bug 41563: Tidy kohaTable - acqui/duplicate_orders.tt
Bug 41563: Tidy kohaTable - acqui/histsearch.tt
Bug 41563: Tidy kohaTable - acqui/invoice.tt
Bug 41563: Tidy kohaTable - acqui/lateorders.tt
Bug 41563: Tidy kohaTable - acqui/newordersuggestion.tt
Bug 41563: Tidy kohaTable - acqui/orderreceive.tt
Bug 41563: Tidy kohaTable - acqui/parcel.tt
Bug 41563: Tidy kohaTable - acqui/vendor_issues.tt
Bug 41563: acqui - auto tidy
Bug 41563: Tidy kohaTable - acqui/acqui-home.tt
Bug 41563: Tidy kohaTable - acqui/basket.tt
Bug 41563: Tidy kohaTable - acqui/basketgroup.tt
Bug 41563: Tidy kohaTable - acqui/duplicate_orders.tt
Bug 41563: Tidy kohaTable - acqui/histsearch.tt
Bug 41563: Tidy kohaTable - acqui/invoice.tt
Bug 41563: Tidy kohaTable - acqui/lateorders.tt
Bug 41563: Tidy kohaTable - acqui/newordersuggestion.tt
Bug 41563: Tidy kohaTable - acqui/orderreceive.tt
Bug 41563: Tidy kohaTable - acqui/parcel.tt
Bug 41563: Tidy kohaTable - acqui/vendor_issues.tt
Bug 41563: acqui - auto tidy
Bug 41563: (follow-up) Fix two typos
Bug 41563: (follow-up) Tidy parcel.tt
Bug 41563: Remove JS error from newordersuggestion
Bug 41563: (follow-up) Tidy parcel.tt
Bug 41563: Remove JS error from newordersuggestion
Bug 41563: Tidy kohaTable - acqui/acqui-home.tt
Bug 41563: Tidy kohaTable - acqui/basket.tt
Bug 41563: Tidy kohaTable - acqui/basketgroup.tt
Bug 41563: Tidy kohaTable - acqui/duplicate_orders.tt
Bug 41563: Tidy kohaTable - acqui/histsearch.tt
Bug 41563: Tidy kohaTable - acqui/invoice.tt
Bug 41563: Tidy kohaTable - acqui/lateorders.tt
Bug 41563: Tidy kohaTable - acqui/newordersuggestion.tt
Bug 41563: Tidy kohaTable - acqui/orderreceive.tt
Bug 41563: Tidy kohaTable - acqui/parcel.tt
Bug 41563: Tidy kohaTable - acqui/vendor_issues.tt
Bug 41563: acqui - auto tidy
Bug 41563: (follow-up) Fix two typos
Bug 41563: (follow-up) Tidy parcel.tt
Bug 41563: Remove JS error from newordersuggestion
Bug 41563: (follow-up 2) Tidy parcel.tt

Description Jonathan Druart 2026-01-09 13:53:33 UTC

    
Comment 1 Jonathan Druart 2026-01-09 14:39:59 UTC
Created attachment 191069 [details] [review]
Bug 41563: Tidy kohaTable - acqui/acqui-home.tt

See bug 41324 comment 6
1. Variable serialization
Comment 2 Jonathan Druart 2026-01-09 14:40:00 UTC
Created attachment 191070 [details] [review]
Bug 41563: Tidy kohaTable - acqui/basket.tt

See bug 41324 comment 6
1. Variable serialization
3. "table_settings" variable
Comment 3 Jonathan Druart 2026-01-09 14:40:01 UTC
Created attachment 191071 [details] [review]
Bug 41563: Tidy kohaTable - acqui/basketgroup.tt

See bug 41324 comment 6
1. Variable serialization
Comment 4 Jonathan Druart 2026-01-09 14:40:03 UTC
Created attachment 191072 [details] [review]
Bug 41563: Tidy kohaTable - acqui/duplicate_orders.tt

See bug 41324 comment 6
1. Variable serialization
Comment 5 Jonathan Druart 2026-01-09 14:40:04 UTC
Created attachment 191073 [details] [review]
Bug 41563: Tidy kohaTable - acqui/histsearch.tt

See bug 41324 comment 6
1. Variable serialization
Comment 6 Jonathan Druart 2026-01-09 14:40:05 UTC
Created attachment 191074 [details] [review]
Bug 41563: Tidy kohaTable - acqui/invoice.tt

See bug 41324 comment 6
1. Variable serialization
Comment 7 Jonathan Druart 2026-01-09 14:40:07 UTC
Created attachment 191075 [details] [review]
Bug 41563: Tidy kohaTable - acqui/lateorders.tt

See bug 41324 comment 6
1. Variable serialization
Comment 8 Jonathan Druart 2026-01-09 14:40:08 UTC
Created attachment 191076 [details] [review]
Bug 41563: Tidy kohaTable - acqui/newordersuggestion.tt

See bug 41324 comment 6
1. Variable serialization
Comment 9 Jonathan Druart 2026-01-09 14:40:10 UTC
Created attachment 191077 [details] [review]
Bug 41563: Tidy kohaTable - acqui/orderreceive.tt

See bug 41324 comment 6
1. Variable serialization
2. Use of permissions and sysprefs

We also removed 'UniqueItemFields' from the controller.
Comment 10 Jonathan Druart 2026-01-09 14:40:11 UTC
Created attachment 191078 [details] [review]
Bug 41563: Tidy kohaTable - acqui/parcel.tt

See bug 41324 comment 6
1. Variable serialization
2. Use of permissions and sysprefs
Comment 11 Jonathan Druart 2026-01-09 14:40:12 UTC
Created attachment 191079 [details] [review]
Bug 41563: Tidy kohaTable - acqui/vendor_issues.tt

See bug 41324 comment 6
1. Variable serialization
Comment 12 Jonathan Druart 2026-01-09 14:40:13 UTC
Created attachment 191080 [details] [review]
Bug 41563: acqui - auto tidy

Patch from commit d0220eb
Comment 13 Owen Leonard 2026-01-12 16:55:22 UTC
Created attachment 191290 [details] [review]
Bug 41563: Tidy kohaTable - acqui/acqui-home.tt

See bug 41324 comment 6
1. Variable serialization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 14 Owen Leonard 2026-01-12 16:55:26 UTC
Created attachment 191291 [details] [review]
Bug 41563: Tidy kohaTable - acqui/basket.tt

See bug 41324 comment 6
1. Variable serialization
3. "table_settings" variable

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 15 Owen Leonard 2026-01-12 16:55:29 UTC
Created attachment 191292 [details] [review]
Bug 41563: Tidy kohaTable - acqui/basketgroup.tt

See bug 41324 comment 6
1. Variable serialization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 16 Owen Leonard 2026-01-12 16:55:33 UTC
Created attachment 191293 [details] [review]
Bug 41563: Tidy kohaTable - acqui/duplicate_orders.tt

See bug 41324 comment 6
1. Variable serialization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 17 Owen Leonard 2026-01-12 16:55:36 UTC
Created attachment 191294 [details] [review]
Bug 41563: Tidy kohaTable - acqui/histsearch.tt

See bug 41324 comment 6
1. Variable serialization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 18 Owen Leonard 2026-01-12 16:55:38 UTC
Created attachment 191295 [details] [review]
Bug 41563: Tidy kohaTable - acqui/invoice.tt

See bug 41324 comment 6
1. Variable serialization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 19 Owen Leonard 2026-01-12 16:55:41 UTC
Created attachment 191296 [details] [review]
Bug 41563: Tidy kohaTable - acqui/lateorders.tt

See bug 41324 comment 6
1. Variable serialization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 20 Owen Leonard 2026-01-12 16:55:44 UTC
Created attachment 191297 [details] [review]
Bug 41563: Tidy kohaTable - acqui/newordersuggestion.tt

See bug 41324 comment 6
1. Variable serialization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 21 Owen Leonard 2026-01-12 16:55:47 UTC
Created attachment 191298 [details] [review]
Bug 41563: Tidy kohaTable - acqui/orderreceive.tt

See bug 41324 comment 6
1. Variable serialization
2. Use of permissions and sysprefs

We also removed 'UniqueItemFields' from the controller.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 22 Owen Leonard 2026-01-12 16:55:50 UTC
Created attachment 191299 [details] [review]
Bug 41563: Tidy kohaTable - acqui/parcel.tt

See bug 41324 comment 6
1. Variable serialization
2. Use of permissions and sysprefs

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 23 Owen Leonard 2026-01-12 16:55:53 UTC
Created attachment 191300 [details] [review]
Bug 41563: Tidy kohaTable - acqui/vendor_issues.tt

See bug 41324 comment 6
1. Variable serialization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 24 Owen Leonard 2026-01-12 16:55:56 UTC
Created attachment 191301 [details] [review]
Bug 41563: acqui - auto tidy

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 25 Owen Leonard 2026-01-12 16:55:59 UTC
Created attachment 191302 [details] [review]
Bug 41563: (follow-up) Fix two typos
Comment 26 Owen Leonard 2026-01-12 16:56:03 UTC
Created attachment 191303 [details] [review]
Bug 41563: (follow-up) Tidy parcel.tt
Comment 27 Jonathan Druart 2026-01-26 12:15:09 UTC
Created attachment 192026 [details] [review]
Bug 41563: Remove JS error from newordersuggestion

Not caused by this patchset but it's a good place to fix it (and not add
a conflict)

Uncaught TypeError: can't access property "DataTable", suggestionst is undefined
Comment 28 Jonathan Druart 2026-02-09 10:54:56 UTC
Created attachment 192730 [details] [review]
Bug 41563: (follow-up) Tidy parcel.tt

Patch from commit d3cee2d
Comment 29 Jonathan Druart 2026-02-09 10:54:57 UTC
Created attachment 192731 [details] [review]
Bug 41563: Remove JS error from newordersuggestion

Not caused by this patchset but it's a good place to fix it (and not add
a conflict)

Uncaught TypeError: can't access property "DataTable", suggestionst is undefined
Comment 30 Jonathan Druart 2026-02-09 10:55:29 UTC
Fixed conflict with bug 41420
Comment 31 Paul Derscheid 2026-02-09 12:11:54 UTC
Created attachment 192748 [details] [review]
Bug 41563: Tidy kohaTable - acqui/acqui-home.tt

See bug 41324 comment 6
1. Variable serialization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 32 Paul Derscheid 2026-02-09 12:11:57 UTC
Created attachment 192749 [details] [review]
Bug 41563: Tidy kohaTable - acqui/basket.tt

See bug 41324 comment 6
1. Variable serialization
3. "table_settings" variable

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 33 Paul Derscheid 2026-02-09 12:11:59 UTC
Created attachment 192750 [details] [review]
Bug 41563: Tidy kohaTable - acqui/basketgroup.tt

See bug 41324 comment 6
1. Variable serialization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 34 Paul Derscheid 2026-02-09 12:12:02 UTC
Created attachment 192751 [details] [review]
Bug 41563: Tidy kohaTable - acqui/duplicate_orders.tt

See bug 41324 comment 6
1. Variable serialization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 35 Paul Derscheid 2026-02-09 12:12:04 UTC
Created attachment 192752 [details] [review]
Bug 41563: Tidy kohaTable - acqui/histsearch.tt

See bug 41324 comment 6
1. Variable serialization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 36 Paul Derscheid 2026-02-09 12:12:07 UTC
Created attachment 192753 [details] [review]
Bug 41563: Tidy kohaTable - acqui/invoice.tt

See bug 41324 comment 6
1. Variable serialization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 37 Paul Derscheid 2026-02-09 12:12:09 UTC
Created attachment 192754 [details] [review]
Bug 41563: Tidy kohaTable - acqui/lateorders.tt

See bug 41324 comment 6
1. Variable serialization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 38 Paul Derscheid 2026-02-09 12:12:12 UTC
Created attachment 192755 [details] [review]
Bug 41563: Tidy kohaTable - acqui/newordersuggestion.tt

See bug 41324 comment 6
1. Variable serialization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 39 Paul Derscheid 2026-02-09 12:12:14 UTC
Created attachment 192756 [details] [review]
Bug 41563: Tidy kohaTable - acqui/orderreceive.tt

See bug 41324 comment 6
1. Variable serialization
2. Use of permissions and sysprefs

We also removed 'UniqueItemFields' from the controller.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 40 Paul Derscheid 2026-02-09 12:12:17 UTC
Created attachment 192757 [details] [review]
Bug 41563: Tidy kohaTable - acqui/parcel.tt

See bug 41324 comment 6
1. Variable serialization
2. Use of permissions and sysprefs

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 41 Paul Derscheid 2026-02-09 12:12:20 UTC
Created attachment 192758 [details] [review]
Bug 41563: Tidy kohaTable - acqui/vendor_issues.tt

See bug 41324 comment 6
1. Variable serialization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 42 Paul Derscheid 2026-02-09 12:12:23 UTC
Created attachment 192759 [details] [review]
Bug 41563: acqui - auto tidy

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 43 Paul Derscheid 2026-02-09 12:12:25 UTC
Created attachment 192760 [details] [review]
Bug 41563: (follow-up) Fix two typos

Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 44 Paul Derscheid 2026-02-09 12:12:28 UTC
Created attachment 192761 [details] [review]
Bug 41563: (follow-up) Tidy parcel.tt

Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 45 Paul Derscheid 2026-02-09 12:12:30 UTC
Created attachment 192762 [details] [review]
Bug 41563: Remove JS error from newordersuggestion

Not caused by this patchset but it's a good place to fix it (and not add
a conflict)

Uncaught TypeError: can't access property "DataTable", suggestionst is undefined

Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 46 Lucas Gass (lukeg) 2026-02-10 17:54:17 UTC
Nice work everyone!

Pushed to main for 26.05
Comment 47 Jonathan Druart 2026-02-11 08:12:37 UTC
Created attachment 192963 [details] [review]
Bug 41563: (follow-up 2) Tidy parcel.tt

Patch from commit 9ee2576
Comment 48 Lucas Gass (lukeg) 2026-02-12 14:59:11 UTC
follow-up pushed to main