|
Description
Caroline Cyr La Rose
2026-01-22 17:36:21 UTC
Created attachment 191989 [details] [review] Bug 41689: Make patron message labels translatable Created attachment 191993 [details] [review] Bug 41689: Make patron message labels translatable To Test: BEFORE APPLYING PATCH: 1- Go to any patron account > Add message 2- Add a message for: "Staff - Internal note" 3- Add a second message for: "OPAC - [NAME OF THE PATRON SELECTED]" ** NOTE: make sure to have the LAST version of the translation file (.po) or it might not work. (from: koha-traductions-main) 4- Add any language (I'll use french-Canada, fr-CA, in this case): From your koha instance, enter on the command line: ./misc/translator/translate install fr-CA 5- Go to Administration > System preferences > enter language 6- Make sure to check 'Français (fr-CA)' box from the 'StaffInterfaceLanguages'preference and save. 7- Go back to the specific patron in which you added the messages 8- Switch language to 'Français' (bottom left corner) 9- Notice that: --> 'OPAC' is still the same (Since we spell OPAC the same way in both english and french. However, it might not be the case in other languages). --> 'Staff note' is not translated. 10- apply patch AFTER APPLYING PATCH: 11 - From you koha instance, enter on the command line: ./misc/translator/translate update fr-CA ./misc/translator/translate install fr-CA 12- Reload patron's page 13- Notice that 'Staff note' is now translated ** You should see this output: 'Note interne' Created attachment 191996 [details] [review] Bug 41689: Make patron message labels translatable To Test: BEFORE APPLYING PATCH: 1- Go to any patron account > Add message 2- Add a message for: "Staff - Internal note" 3- Add a second message for: "OPAC - [NAME OF THE PATRON SELECTED]" 4- Add any language (I'll use french-Canada, fr-CA, in this case): From your koha instance, enter on the command line: ./misc/translator/translate install fr-CA 5- Go to Administration > System preferences > enter language 6- Make sure to check 'Français (fr-CA)' box from the 'StaffInterfaceLanguages'preference and save. 7- Go back to the specific patron in which you added the messages 8- Switch language to 'Français' (bottom left corner) 9- Notice that: --> 'OPAC' is still the same (Since we spell OPAC the same way in both english and french. However, it might not be the case in other languages). --> 'Staff note' is not translated. 10- apply patch AFTER APPLYING PATCH: 11 - From you koha instance, enter on the command line: ./misc/translator/translate update fr-CA ./misc/translator/translate install fr-CA 12- Reload patron's page 13- Notice that 'Staff note' is now translated ** You should see this output: 'Note interne' Created attachment 191998 [details] [review] Bug 41689: Make patron message labels translatable To Test: BEFORE APPLYING PATCH: 1- Go to any patron account > Add message 2- Add a message for: "Staff - Internal note" 3- Add a second message for: "OPAC - [NAME OF THE PATRON SELECTED]" 4- Add any language (I'll use french-Canada, fr-CA, in this case): From your koha instance, enter on the command line: ./misc/translator/translate install fr-CA 5- Go to Administration > System preferences > enter language 6- Make sure to check 'Français (fr-CA)' box from the 'StaffInterfaceLanguages'preference and save. 7- Go back to the specific patron in which you added the messages 8- Switch language to 'Français' (bottom left corner) 9- Notice that: --> 'OPAC' is still the same (Since we spell OPAC the same way in both english and french. However, it might not be the case in other languages). --> 'Staff note' is not translated. 10- apply patch AFTER APPLYING PATCH: 11 - From you koha instance, enter on the command line: ./misc/translator/translate update fr-CA ./misc/translator/translate install fr-CA 12- Reload patron's page 13- Notice that 'Staff note' is now translated ** You should see this output: 'Note interne' Signed-off-by: David Nind <david@davidnind.com> 1) QA checks - fail for tidy, but fixed Processing files [RUNNING] koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc [FAIL] koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc Result: [FAIL] koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc` Processing additional checks PASS! Please check your setup, the tidy should happen automatically :) I tidied and amended the patch, it was only a one line whitespace change. Created attachment 192599 [details] [review] Bug 41689: Make patron message labels translatable To Test: BEFORE APPLYING PATCH: 1- Go to any patron account > Add message 2- Add a message for: "Staff - Internal note" 3- Add a second message for: "OPAC - [NAME OF THE PATRON SELECTED]" 4- Add any language (I'll use french-Canada, fr-CA, in this case): From your koha instance, enter on the command line: ./misc/translator/translate install fr-CA 5- Go to Administration > System preferences > enter language 6- Make sure to check 'Français (fr-CA)' box from the 'StaffInterfaceLanguages'preference and save. 7- Go back to the specific patron in which you added the messages 8- Switch language to 'Français' (bottom left corner) 9- Notice that: --> 'OPAC' is still the same (Since we spell OPAC the same way in both english and french. However, it might not be the case in other languages). --> 'Staff note' is not translated. 10- apply patch AFTER APPLYING PATCH: 11 - From you koha instance, enter on the command line: ./misc/translator/translate update fr-CA ./misc/translator/translate install fr-CA 12- Reload patron's page 13- Notice that 'Staff note' is now translated ** You should see this output: 'Note interne' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Nice work everyone! Pushed to main for 26.05 |