| Summary: | Make running the holds queue on click optional | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Donna <bwsdonna> |
| Component: | Circulation | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | Failed QA --- | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gmcharlt, jrobb, kyle, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This patch adds a system preference 'UseHoldsQueueFilterOptions'. When it is enabled it prevents the direct running of the holds queue by clicking on the 'Holds queue' links. With it enabled it will present the user with filter options before running the holds queue. This is to prevent excessive running of the holds queue which can cause slowdowns on larger systems.
|
Version(s) released in: | |
| Circulation function: | |||
| Bug Depends on: | 36455 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 41788: Add system preference UseHoldsQueueFilterOptions
Bug 41788: Implement UseHoldsQueueFilterOptions |
||
|
Description
Donna
2026-02-06 14:37:26 UTC
Created attachment 192634 [details] [review] Bug 41788: Add system preference UseHoldsQueueFilterOptions Created attachment 192635 [details] [review] Bug 41788: Implement UseHoldsQueueFilterOptions To test: 1. Apply patch, updatedatabase, restart_all 2. Search for new system preference UseHoldsQueueFilterOptions. 3. Disable it, and navigate to Circulation -> Holds queue 4. With the pref disabled the holds queue should run with asking for filters. 5. Also try the Holds queue link in the circ-nav ( left navigation ) panel, clicking it should automatically run the holds queue. 6. Also try the link in the breadcrumbs, clicking it should automatically run the holds queue. 7. Now enabled the pref. 8. With the pref enabled navigate to Circulation -> Holds queue, the holds queue link should present filters but NOT run the holds queue. 9. Test the Holds queue link in the circ-nav ( left navigation ) panel, click it should present filters but NOT run the holds queue. 10. Also try the link in the breadcrumbs, clicking them should presnt filters but not run the holds queue. It looks like there may be some errors in the sysprefs.sql file at lines 491 and 581. It might be good to add the phrase "filter options" to the syspref description to add some clarity: [Enable/Disable] filter options when running the holds queue. Other than that it seems to work great! (In reply to Jason Robb from comment #3) > It looks like there may be some errors in the sysprefs.sql file at lines 491 > and 581. > > It might be good to add the phrase "filter options" to the syspref > description to add some clarity: [Enable/Disable] filter options when > running the holds queue. > > Other than that it seems to work great! What errors do you see? 491 /kohadevbox/koha/installer/data/mysql/mandatory/sysprefs.sql('OPACAllowUserToChooseBranch','1',NULL,'Allow the user to choose the branch they want to pickup their hold from','YesNo'),
581 ('OpacShowRecentComments','0',NULL,'If ON a link to recent c/kohadevbox/koha/installer/data/mysql/mandatory/sysprefs.sqlomments will appear in the OPAC masthead','YesNo'),
|