To reduce clicks for library staff, defaulting the hold queue link on circulation home to the logged in library would be helpful, either as an option or as the default behavior with the option to run it for a different branch from the queue.
Agree, this saves clicks. I'm currently using jQuery for this: //Point holds queue button directly to logged in library's queue var libcode = $('#logged-in-info-full .logged-in-branch-code').text(); $('#circ_circulation-home .circ-button:contains("Holds queue")').attr('href', '/cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=' + libcode +'&itemtypeslimit=&ccodeslimit=&locationslimit=&run_report=1');
Created attachment 178043 [details] [review] Bug 36455: Default the hold queue link to your logged in library This patch reduces the number of click for the average librarian user. To test: 1. Change your logged in branch to something other than Centerville 2. Navigate to the circulation home page 3. Click on the Holds queue link 4. Observe that you have to hit Submit to continue 5. Apply patch 6. Repeat steps 1 and 2 7. Observe that the holds queue comes up with your branch preselected
Created attachment 178044 [details] [review] Bug 36455: Default the hold queue link to your logged in library This patch reduces the number of click for the average librarian user. To test: 1. Change your logged in branch to something other than Centerville 2. Navigate to the circulation home page 3. Click on the Holds queue link 4. Observe that you have to hit Submit to continue 5. Apply patch 6. Repeat steps 1 and 2 7. Observe that the holds queue comes up with your branch preselected Mentored-by: "Lisette Scheer <lisette@bywatersolutions.com>"
Created attachment 178045 [details] [review] Bug 36455: Default the hold queue link to your logged in library This patch reduces the number of click for the average librarian user. To test: 1. Change your logged in branch to something other than Centerville 2. Navigate to the circulation home page 3. Click on the Holds queue link 4. Observe that you have to hit Submit to continue 5. Apply patch 6. Repeat steps 1 and 2 7. Observe that the holds queue comes up with your branch preselected Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signing off here because I like avoiding clicks. Do we want to introduce this same behavior to the same link in circ-nav.inc?
(In reply to Lucas Gass (lukeg) from comment #5) > Signing off here because I like avoiding clicks. Do we want to introduce > this same behavior to the same link in circ-nav.inc? Our comments collided midair. Apparently I'm meaner than Lucas, was gonna Fail QA on this Works as described, strictly, but this patch doesn't change the behavior of the Holds Queue link on the circ sidebar, resulting in confusing inconsistency. To recreate, with patch applied: 1 - go to circ homepage 2 - click holds queue, see it loads the queue for your logged-in branch immediately 3 - click Holds Awaiting Pickup in the left sidebar 4 - click Holds Queue in the left sidebar 5 - you're back at the queue, but this time it has not loaded results immediately
Please look at the previous comment. It needs attention. Left or right?
Created attachment 179276 [details] [review] Bug 36455: (follow-up) Default the hold queue link to your logged in library Also fixed the link on circ-nav and the breadcrumbs links.
Created attachment 179277 [details] [review] Bug 36455: Default the hold queue link to your logged in library This patch reduces the number of click for the average librarian user. To test: 1. Change your logged in branch to something other than Centerville 2. Navigate to the circulation home page 3. Click on the Holds queue link 4. Observe that you have to hit Submit to continue 5. Apply patch 6. Repeat steps 1 and 2 7. Observe that the holds queue comes up with your branch preselected Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Created attachment 179278 [details] [review] Bug 36455: (follow-up) Default the hold queue link to your logged in library Also fixed the link on circ-nav and the breadcrumbs links. Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
I'll be the mean one, then, in case it gets missed in QA. >+ ?branchlimit=[% Branches.GetLoggedInBranchcode | html %] When you are filtering a URL parameter, you want the filter "uri" rather than "html." There's nothing (other than our possible sloppiness elsewhere) stopping someone from having a branchcode us+them which when passed through the uri filter is us%2Bthem and it works, but when passed through the html filter stays us+them which in a URL is us them and that branch with a space in its branchcode wouldn't have any holds in its queue.
Everyone can set "Failed QA" and should if they notice something, nto really mean, especially when accompanied by helpful information.
Created attachment 180794 [details] [review] Bug 36455: (follow-up) Changed html filters to uri
Created attachment 180796 [details] [review] Bug 36455: Default the hold queue link to your logged in library This patch reduces the number of click for the average librarian user. To test: 1. Change your logged in branch to something other than Centerville 2. Navigate to the circulation home page 3. Click on the Holds queue link 4. Observe that you have to hit Submit to continue 5. Apply patch 6. Repeat steps 1 and 2 7. Observe that the holds queue comes up with your branch preselected Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Created attachment 180797 [details] [review] Bug 36455: (follow-up) Default the hold queue link to your logged in library Also fixed the link on circ-nav and the breadcrumbs links. Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Created attachment 180798 [details] [review] Bug 36455: (follow-up) Changed html filters to uri Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
(In reply to Jason Robb from comment #13) > Created attachment 180794 [details] [review] [review] > Bug 36455: (follow-up) Changed html filters to uri I created a library with the branchcode "BAD!CODE" and the holds queue url worked as desired. I didn't click around Koha to see if that code broke unrelated things but it made me quite nervous :)
The patch no longer applies 8-(.. I was going to add my sign-off, so that one of the others could count as QA. git bz apply 36455 Bug 36455 - Default the hold queue link to your logged in library 180796 - Bug 36455: Default the hold queue link to your logged in library 180797 - Bug 36455: (follow-up) Default the hold queue link to your logged in library 180798 - Bug 36455: (follow-up) Changed html filters to uri Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36455: Default the hold queue link to your logged in library Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 36455: Default the hold queue link to your logged in library