Bug 41916

Summary: SIP2 module cypress tests failing
Product: Koha Reporter: Pedro Amorim <pedro.amorim>
Component: Architecture, internals, and plumbingAssignee: Pedro Amorim <pedro.amorim>
Status: Pushed to main --- QA Contact: Paul Derscheid <paul.derscheid>
Severity: normal    
Priority: P5 - low CC: jonathan.druart, lucas, pedro.amorim
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
26.05.00
Version(s) released in:
Circulation function:
Bug Depends on: 37893    
Bug Blocks:    
Attachments: Bug 41916: Clean-up obsolete code
Bug 41916: Update Cypress tests
Bug 41916: Clean-up obsolete code
Bug 41916: Update Cypress tests
Bug 41916: Clean-up obsolete code
Bug 41916: Update Cypress tests

Description Pedro Amorim 2026-02-24 15:34:41 UTC

    
Comment 1 Pedro Amorim 2026-02-24 15:38:34 UTC
Created attachment 193770 [details] [review]
Bug 41916: Clean-up obsolete code

No longer needed after bug 40191, but because both that and bug 37893 went in close to each other, this remained.
Removing this fixes the toolbar buttons on the SIP2 account form and fixes the console warning that was causing a failure in cypress tests
Comment 2 Pedro Amorim 2026-02-24 15:38:36 UTC
Created attachment 193771 [details] [review]
Bug 41916: Update Cypress tests

Button is now 'Save' not 'Submit' after bug 40191

On ktd:
cypress run --spec t/cypress/integration/SIP2/*

All tests must pass
Comment 3 Lucas Gass (lukeg) 2026-02-24 15:56:58 UTC
Created attachment 193772 [details] [review]
Bug 41916: Clean-up obsolete code

No longer needed after bug 40191, but because both that and bug 37893 went in close to each other, this remained.
Removing this fixes the toolbar buttons on the SIP2 account form and fixes the console warning that was causing a failure in cypress tests

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Lucas Gass (lukeg) 2026-02-24 15:57:01 UTC
Created attachment 193773 [details] [review]
Bug 41916: Update Cypress tests

Button is now 'Save' not 'Submit' after bug 40191

On ktd:
cypress run --spec t/cypress/integration/SIP2/*

All tests must pass

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 5 Paul Derscheid 2026-02-25 15:33:49 UTC
Created attachment 193906 [details] [review]
Bug 41916: Clean-up obsolete code

No longer needed after bug 40191, but because both that and bug 37893 went in close to each other, this remained.
Removing this fixes the toolbar buttons on the SIP2 account form and fixes the console warning that was causing a failure in cypress tests

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 6 Paul Derscheid 2026-02-25 15:33:51 UTC
Created attachment 193907 [details] [review]
Bug 41916: Update Cypress tests

Button is now 'Save' not 'Submit' after bug 40191

On ktd:
cypress run --spec t/cypress/integration/SIP2/*

All tests must pass

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 7 Lucas Gass (lukeg) 2026-02-25 15:48:24 UTC
Pushed to main for 26.05.00