| Summary: | "New patron" menu button broken on circulation patron select screen | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Circulation | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | major | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | f.demians, gmcharlt |
| Version: | rel_3_2 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Proposed fix
Additional change Proposed patch |
||
Created attachment 2368 [details] [review] Proposed fix Patch pushed. Please test and close. Created attachment 2382 [details] [review] Additional change Menu was working on members-home.pl but not on members.pl Pushed follow-up patch. Created attachment 2501 [details] [review] Proposed patch Comment on attachment 2501 [details] [review] Proposed patch The pull down for category in patron's advanced search was only showing any and no patron categories. *** Bug 5188 has been marked as a duplicate of this bug. *** > *** Bug 5188 has been marked as a duplicate of this bug. *** I agree that your patch should solved bug 5188. I'd have find it if it had been attached to a separate bug... Thanks Katrin. Tested successfully on current head, closing bug. Plz reopen if you still see problems. |
If type a patron name into the "check out" form and come to the page where you can choose from a list of existing patrons, there is a "New" menu button which is supposed to offer a drop-down list of patron categories. This button is broken, displaying no menu at all. The markup for the button comes from patron-toolbar.inc which is also used on members-home.pl. The button on members-home.pl works fine. In the template is a loop for displaying the categories: <!--TMPL_LOOP Name="categoryloop"--> { text: "<!--TMPL_VAR Name="description"-->", url: "/cgi-bin/koha/members/memberentry.pl?op=add&categorycode=<!--TMPL_VAR Name="categorycode"-->" }, <!--/TMPL_LOOP--> members-home.pl contains code to build this loop variable: my @categories=C4::Category->all; $template->param( branchloop=>(defined $branch?GetBranchesLoop($branch):GetBranchesLoop()), categoryloop=>\@categories, ); There is no mention of "categoryloop" in circulation.pl