Summary: | Use other name rather than first name when referring to the user | ||
---|---|---|---|
Product: | Koha | Reporter: | Robin Sheat <robin> |
Component: | OPAC | Assignee: | Robin Sheat <robin> |
Status: | CLOSED WONTFIX | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | chris, claire.hernandez, nengard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2930 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
proposed patch
proposed patch Proposed patch Proposed patch |
Description
Robin Sheat
2010-08-25 02:28:46 UTC
Created attachment 2569 [details] [review] proposed patch This patch is for testing, once it gets through our internal QA, I'll change the status and send it to the list. Created attachment 2581 [details] [review] proposed patch Fixes a few issues found by QA. Patch doesn't apply for me on current HEAD. Created attachment 2839 [details] [review] Proposed patch Updated the patch rebased against master. I'm not sure why the other version didn't apply, it gave me a strange error, however rebasing from the original branch was smooth enough. Created attachment 2840 [details] [review] Proposed patch For reasons I don't quite understand, the previous one had a couple of bits missing. This includes them. I find two instances where the "showname" variable doesn't seem to be making it through: opac-sendbasket.pl and opac-sendshelf.pl. In both cases the email I get omits the other name and sends only the surname. This bug is mentioned in: Bug 5172 - prefer 'other name' over 'first name' if available. http://lists.koha-community.org/pipermail/koha-patches/2010-December/013256.html Bug 5172 - prefer 'other name' over 'first name' if available. http://lists.koha-community.org/pipermail/koha-patches/2010-December/013257.html Bug 5172 - prefer 'other name' over 'first name' if available. http://lists.koha-community.org/pipermail/koha-patches/2010-December/013265.html Bug 5172 - prefer 'other name' over 'first name' if available. http://lists.koha-community.org/pipermail/koha-patches/2010-December/013266.html Bug 5172 - prefer 'other name' over 'first name' if available. http://lists.koha-community.org/pipermail/koha-patches/2010-December/013272.html Bug 5172 - prefer 'other name' over 'first name' if available. http://lists.koha-community.org/pipermail/koha-patches/2010-December/013283.html Bug 5172 - prefer 'other name' over 'first name' if available. http://lists.koha-community.org/pipermail/koha-patches/2010-December/013258.html I'd argue that it should show Mr Firstname "Othername" Surname instead. Not everyone is using 'Othername' the same way. Nicole Failed to apply on current master Applying: Bug 5172 - prefer 'other name' over 'first name' if available. Using index info to reconstruct a base tree... <stdin>:28: trailing whitespace. # 'showname' which is the alternate form the user's first name if warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging C4/Members.pm Auto-merging koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-account.tmpl Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-messaging.tmpl Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-passwd.tmpl CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-passwd.tmpl Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-readingrecord.tmpl Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tmpl CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tmpl Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tmpl Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-userdetails.tmpl Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-userupdate.tmpl Auto-merging opac/opac-sendbasket.pl Auto-merging opac/opac-sendshelf.pl Failed to merge in the changes. Needs a new patch (In reply to comment #8) > I'd argue that it should show Mr Firstname "Othername" Surname instead. Not > everyone is using 'Othername' the same way. I agree. See Bug 2930. Fixed in a slightly different manner in Bug 2930. I think this one can be ignored. |