Bug 5172 - Use other name rather than first name when referring to the user
Summary: Use other name rather than first name when referring to the user
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement with 5 votes (vote)
Assignee: Robin Sheat
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-25 02:28 UTC by Robin Sheat
Modified: 2014-12-07 20:03 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
proposed patch (19.57 KB, patch)
2010-08-25 02:32 UTC, Robin Sheat
Details | Diff | Splinter Review
proposed patch (20.82 KB, patch)
2010-08-27 03:30 UTC, Robin Sheat
Details | Diff | Splinter Review
Proposed patch (19.57 KB, patch)
2010-12-13 22:54 UTC, Robin Sheat
Details | Diff | Splinter Review
Proposed patch (20.48 KB, patch)
2010-12-13 23:12 UTC, Robin Sheat
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Sheat 2010-08-25 02:28:46 UTC
In the OPAC, the 'Other Name' field should be used when referring to the user, if it's been supplied. For example, "Mr Firstname Surname" should be "Mr Othername Surname" if there is a defined Othername.
Comment 1 Robin Sheat 2010-08-25 02:32:49 UTC Comment hidden (obsolete)
Comment 2 Robin Sheat 2010-08-27 03:30:28 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2010-12-13 16:21:20 UTC
Patch doesn't apply for me on current HEAD.
Comment 4 Robin Sheat 2010-12-13 22:54:46 UTC Comment hidden (obsolete)
Comment 5 Robin Sheat 2010-12-13 23:12:51 UTC
Created attachment 2840 [details] [review]
Proposed patch

For reasons I don't quite understand, the previous one had a couple of bits missing. This includes them.
Comment 6 Owen Leonard 2011-01-10 14:14:26 UTC
I find two instances where the "showname" variable doesn't seem to be making it through: opac-sendbasket.pl and opac-sendshelf.pl. In both cases the email I get omits the other name and sends only the surname.
Comment 7 MJ Ray (software.coop) 2011-01-11 12:58:12 UTC
This bug is mentioned in:
Bug 5172 - prefer 'other name' over 'first	name' if available. http://lists.koha-community.org/pipermail/koha-patches/2010-December/013256.html
Bug 5172 - prefer 'other name' over 'first name' if available. http://lists.koha-community.org/pipermail/koha-patches/2010-December/013257.html
Bug 5172 - prefer 'other name' over 'first name' if available. http://lists.koha-community.org/pipermail/koha-patches/2010-December/013265.html
Bug 5172 - prefer 'other name' over 'first name' if available. http://lists.koha-community.org/pipermail/koha-patches/2010-December/013266.html
Bug 5172 - prefer 'other name' over 'first name' if available. http://lists.koha-community.org/pipermail/koha-patches/2010-December/013272.html
Bug 5172 - prefer 'other name' over 'first name' if available. http://lists.koha-community.org/pipermail/koha-patches/2010-December/013283.html
Bug 5172 - prefer 'other name' over	'first name' if available. http://lists.koha-community.org/pipermail/koha-patches/2010-December/013258.html
Comment 8 Nicole C. Engard 2011-03-07 18:43:52 UTC
I'd argue that it should show Mr Firstname "Othername" Surname instead.  Not everyone is using 'Othername' the same way.

Nicole
Comment 9 claire.hernandez@biblibre.com 2011-04-04 12:50:43 UTC
Failed to apply on current master

Applying: Bug 5172 - prefer 'other name' over 'first name' if available.
Using index info to reconstruct a base tree...
<stdin>:28: trailing whitespace.
    # 'showname' which is the alternate form the user's first name if 
warning: 1 line adds whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging C4/Members.pm
Auto-merging koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-account.tmpl
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-messaging.tmpl
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-passwd.tmpl
CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-passwd.tmpl
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-readingrecord.tmpl
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tmpl
CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tmpl
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tmpl
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-userdetails.tmpl
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-userupdate.tmpl
Auto-merging opac/opac-sendbasket.pl
Auto-merging opac/opac-sendshelf.pl
Failed to merge in the changes.
Comment 10 Chris Cormack 2013-01-01 23:40:54 UTC
Needs a new patch
Comment 11 Owen Leonard 2013-01-03 20:45:30 UTC
(In reply to comment #8)
> I'd argue that it should show Mr Firstname "Othername" Surname instead.  Not
> everyone is using 'Othername' the same way.

I agree. See Bug 2930.
Comment 12 Robin Sheat 2013-01-03 21:53:12 UTC
Fixed in a slightly different manner in Bug 2930. I think this one can be ignored.