Summary: | keep track of cancelled orders | ||
---|---|---|---|
Product: | Koha | Reporter: | Paul Poulain <paul.poulain> |
Component: | Acquisitions | Assignee: | Julian Maurice <julian.maurice> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | christophe.croullebois, duncan, jonathan.druart, julian.maurice, koha.sekjal |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
URL: | http://wiki.koha-community.org/wiki/Cancelled_orders_acq_RFC | ||
Change sponsored?: | Sponsored | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 5361, 7163 | ||
Deadline: | 2011-05-01 | ||
Attachments: |
Proposed patch
Signed off patch Rebased patch signed-off |
Description
Paul Poulain
2010-11-02 03:54:36 UTC
In fact, no new tables will be created, aqorders.datecancellationprinted will be used. I'm working on it. Created attachment 6222 [details] [review] Proposed patch Display a table below orders, in basket page, which contains cancelled orders of this basket. Created attachment 6632 [details] [review] Signed off patch Applying: Bug 5358: Show cancelled orders in basket page Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt Recorded preimage for 'koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt' Failed to merge in the changes. Patch failed at 0001 Bug 5358: Show cancelled orders in basket page Created attachment 7011 [details] [review] Rebased patch ok fine, easy and usefull. Signed off Created attachment 7065 [details] [review] signed-off Adds new subroutine and template params to access it. All in all, very clean and easy to read. Existing unit tests passed. Marking Passed QA. Only part missing is a new unit test for the subroutine, but since t/db_dependent/Acquisition.t is a stub now anyway, this shouldn't block the addition of this feature. Steps to reproduce: * open an acquisition basket, with some lines * cancel one of the order line by hitting "Delete order" option => a new table appear, with the cancelled order, below the remaining order lines. Patch pushed, please test Ok in master, marked as resolved |