Summary: | The shelf browser should be able to ignore things like location | ||
---|---|---|---|
Product: | Koha | Reporter: | Robin Sheat <robin> |
Component: | OPAC | Assignee: | Robin Sheat <robin> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | camins, chris, jcamins, julian.maurice, nengard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4367 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Proposed patch
Signed-off patch |
Description
Robin Sheat
2010-12-29 02:10:25 UTC
The implementation of this will probably also allow Bug 4367 to be closed, it makes sense to do them both at the same time. What is the implementation of this? Will it still look at location if it's there? Is there a system preference? I know that we just recently got it looking at both call number and shelving location and I'd hate to lose that functionality. My thinking (suggested by jcamins) is that we'll have three sysprefs: Use homebranch (default: yes), use location (yes), use ccode (no). This will keep the current behaviour by default, but allow it to be changed fairly granularly. Sounds perfect :) Created attachment 2993 [details] [review] Proposed patch Bug 5551 - allow shelf browser filters to be changed This adds three system preferences: ShelfBrowserUsesLocation, ShelfBrowserUsesHomeBranch, and ShelfBrowserUsesCcode. These can be toggled to determine whether the shelf browser will ensure that the items being show will match against location, homebranch, or collection code, respectively. Note that this also involves a bit of a refactor to clean up the shelf browser code. Created attachment 3014 [details] [review] Signed-off patch I have rebased to apply to current head, and signed off on this patch. Pushed, please test This bug is mentioned in: Bug 5551 - allow shelf browser filters to be changed http://lists.koha-community.org/pipermail/koha-patches/2011-January/013602.html Bug 5551 - allow shelf browser filters to be changed http://lists.koha-community.org/pipermail/koha-patches/2011-January/013688.html |