Bug 5653

Summary: default new label layout and sample data have broken call number placeholder
Product: Koha Reporter: Galen Charlton <gmcharlt>
Component: Label/patron card printingAssignee: Galen Charlton <gmcharlt>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: normal    
Priority: PATCH-Sent (DO NOT USE) CC: chris, katrin.fischer
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 6343    
Bug Blocks:    
Attachments: proposed patch
[SIGNED-OFF] bug 5653: use itemcallnumber in bib label layouts
Bug 5653: Follow-up, correction to nb-NO sample creator data

Description Galen Charlton 2011-01-24 21:27:03 UTC
The sample label layout data and the hardcoded default values for a new spine label layout refer to 'callnumber' instead of 'itemcallnumber'.  Consequently, labels based on these layouts will not include the call number unless the user manually updates the layout to use itemcallnumber.
Comment 1 Galen Charlton 2011-01-24 22:19:07 UTC Comment hidden (obsolete)
Comment 2 MJ Ray (software.coop) 2011-02-05 19:00:49 UTC
This bug is mentioned in:
bug 5653: use itemcallnumber in bib label	layouts http://lists.koha-community.org/pipermail/koha-patches/2011-January/013697.html
Comment 3 Katrin Fischer 2011-05-26 05:39:39 UTC
Created attachment 4268 [details] [review]
[SIGNED-OFF] bug 5653: use itemcallnumber in bib label layouts

The sample bib label layouts and the hard-coded default
format_string for new layouts used 'callnumber' when they
should have used 'itemcallnumber', preventing call numbers
from being printed on spine labels that use the system-supplied
layouts.  Besides correcting the sample data, this patch
now also enshrines 'callnumber' as an alias for 'itemcallnumber'.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
After applying patch it works for new and old layouts (itemcallnumber and callnumber).
Comment 4 Katrin Fischer 2011-05-26 05:46:21 UTC
Created attachment 4269 [details] [review]
Bug 5653: Follow-up, correction to nb-NO sample creator data

Corrects callnumber to itemcallnumber in Norwegian sample data.
Comment 5 Chris Cormack 2011-06-12 23:49:30 UTC
Works as advertised, pushed, please test
Comment 6 Jared Camins-Esakov 2012-12-31 00:10:10 UTC
There have been no further reports of problems so I am marking this bug resolved.