Bug 5653 - default new label layout and sample data have broken call number placeholder
Summary: default new label layout and sample data have broken call number placeholder
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Label/patron card printing (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Galen Charlton
QA Contact: Bugs List
URL:
Keywords:
Depends on: 6343
Blocks:
  Show dependency treegraph
 
Reported: 2011-01-24 21:27 UTC by Galen Charlton
Modified: 2013-12-05 20:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
proposed patch (8.25 KB, patch)
2011-01-24 22:19 UTC, Galen Charlton
Details | Diff | Splinter Review
[SIGNED-OFF] bug 5653: use itemcallnumber in bib label layouts (8.44 KB, patch)
2011-05-26 05:39 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 5653: Follow-up, correction to nb-NO sample creator data (2.13 KB, patch)
2011-05-26 05:46 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Galen Charlton 2011-01-24 21:27:03 UTC
The sample label layout data and the hardcoded default values for a new spine label layout refer to 'callnumber' instead of 'itemcallnumber'.  Consequently, labels based on these layouts will not include the call number unless the user manually updates the layout to use itemcallnumber.
Comment 1 Galen Charlton 2011-01-24 22:19:07 UTC Comment hidden (obsolete)
Comment 2 MJ Ray (software.coop) 2011-02-05 19:00:49 UTC
This bug is mentioned in:
bug 5653: use itemcallnumber in bib label	layouts http://lists.koha-community.org/pipermail/koha-patches/2011-January/013697.html
Comment 3 Katrin Fischer 2011-05-26 05:39:39 UTC
Created attachment 4268 [details] [review]
[SIGNED-OFF] bug 5653: use itemcallnumber in bib label layouts

The sample bib label layouts and the hard-coded default
format_string for new layouts used 'callnumber' when they
should have used 'itemcallnumber', preventing call numbers
from being printed on spine labels that use the system-supplied
layouts.  Besides correcting the sample data, this patch
now also enshrines 'callnumber' as an alias for 'itemcallnumber'.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
After applying patch it works for new and old layouts (itemcallnumber and callnumber).
Comment 4 Katrin Fischer 2011-05-26 05:46:21 UTC
Created attachment 4269 [details] [review]
Bug 5653: Follow-up, correction to nb-NO sample creator data

Corrects callnumber to itemcallnumber in Norwegian sample data.
Comment 5 Chris Cormack 2011-06-12 23:49:30 UTC
Works as advertised, pushed, please test
Comment 6 Jared Camins-Esakov 2012-12-31 00:10:10 UTC
There have been no further reports of problems so I am marking this bug resolved.