Summary: | Add the jquery table sorter to borrowers reading record | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Cormack <chris> |
Component: | Patrons | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, nengard, paul.poulain, srdjan |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 5575 | ||
Attachments: |
Proposed Patch
Follow-up fix |
Description
Chris Cormack
2011-02-15 01:39:02 UTC
Created attachment 3155 [details] [review] Proposed Patch Pushed, please test and mark resolved If we're using jQuery to page the table we should eliminate the "Showing Last 50 Items | Show All Items" choices. Created attachment 3160 [details] [review] Follow-up fix - Removing option to show 50 items/show all from script and template - Adding parser to exclude articles in title sort (en only, see Bug 5766) - Setting default sort to 'date due descending' as it was previously signed off on follow up Pushed follow up, please test There is a major problem with this change, for borrowers with large reading histories, loading all the history into the browser and then paging with javascript causes the browser to crash/lock up. It needs to not do this. I suggest reverting the follow up patch, which allows it to limit to the first 50, so it won't crash by default. Then coming up with a better solution We'll try to replace tablesorter with datatable. Failing that we'll implement something of our own to lazy load the history. Srdjan: what could be the timeline for the replacement patch ? If it "in the next 2 weeks", then I won't revert. Otherwise, i'll agree with chris & revert the patch. I believe we can do it in the next two weeks. |