Bug 5760 - Add the jquery table sorter to borrowers reading record
Summary: Add the jquery table sorter to borrowers reading record
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
Depends on:
Blocks: 5575
  Show dependency treegraph
Reported: 2011-02-15 01:39 UTC by Chris Cormack
Modified: 2013-12-05 20:01 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:

Proposed Patch (3.29 KB, patch)
2011-02-15 01:41 UTC, Chris Cormack
Details | Diff | Splinter Review
Follow-up fix (5.74 KB, patch)
2011-02-16 15:26 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2011-02-15 01:39:02 UTC

Comment 1 Chris Cormack 2011-02-15 01:41:39 UTC
Created attachment 3155 [details] [review]
Proposed Patch
Comment 2 Chris Cormack 2011-02-16 01:47:41 UTC
Pushed, please test and mark resolved
Comment 3 Owen Leonard 2011-02-16 14:30:24 UTC
If we're using jQuery to page the table we should eliminate the "Showing Last 50 Items | Show All Items" choices.
Comment 4 Owen Leonard 2011-02-16 15:26:57 UTC
Created attachment 3160 [details] [review]
Follow-up fix

- Removing option to show 50 items/show all from script and template
- Adding parser to exclude articles in title sort (en only, see Bug 5766)
- Setting default sort to 'date due descending' as it was previously
Comment 5 Nicole C. Engard 2011-02-16 17:27:02 UTC
signed off on follow up
Comment 6 Chris Cormack 2011-02-16 20:28:38 UTC
Pushed follow up, please test
Comment 7 Chris Cormack 2011-11-20 22:50:44 UTC
There is a major problem with this change, for borrowers with large reading histories, loading all the history into the browser and then paging with javascript causes the browser to crash/lock up.

It needs to not do this.

I suggest reverting the follow up patch, which allows it to limit to the first 50, so it won't crash by default. Then coming up with a better solution
Comment 8 Srdjan Jankovic 2011-11-21 00:13:26 UTC
We'll try to replace tablesorter with datatable. Failing that we'll implement something of our own to lazy load the history.
Comment 9 Paul Poulain 2011-11-23 11:23:46 UTC
Srdjan: what could be the timeline for the replacement patch ? If it "in the next 2 weeks", then I won't revert. Otherwise, i'll agree with chris & revert the patch.
Comment 10 Srdjan Jankovic 2011-11-24 06:20:19 UTC
I believe we can do it in the next two weeks.