| Summary: | Cart printing truncated in Firefox | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Browser compatibility | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | normal | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, f.demians, judit, koha.sekjal, nengard, paul.poulain |
| Version: | 3.6 | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10108 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7279 |
||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Proposed fix
Revised fix proposed patch (passed QA) Alternate fix |
||
|
Description
Owen Leonard
2011-05-02 19:27:16 UTC
Created attachment 4026 [details] [review] Proposed fix Implementing 100% width and height on <table>,<td>, and <th> as suggested by this post: http://www.piglets.org/serendipity/archives/45-Fixing-truncated-printing-with-Firefox.html I can reproduce this bug in Firefox 3.5. But it doens't exist anymore on Firefox 4.0 (version Mac). I've tested this patch with FF 3.5. I doesn't solve the bug. Created attachment 4377 [details] [review] Revised fix Please be sure to clear your browser's cache before testing. Tested in FF5 on Mac and it was still a bug and the patch fixed it! Signed off. Created attachment 4943 [details] [review] proposed patch (passed QA) QA comment No specific comment, except the signoff from Nicole hasn't been sent, so only my signoff is visible. thx owen, this bug was annoying, and had been reported a long time ago on our support platform (but we hadn't found how to fix it...) Pushed, fixed missing sign off also (Paul you missed your one too, must be something about this bug) I think my fix for this bug should be reverted. It's causing problems like Bug 7279 and font-sizing problems in receipts. well... i'm not sure the 6291 should be reverted, unless, owen, you know how to write a better fix. The 6291 fix solves a major problem (you don't get pages 2+, while bug 7279 is minor (the info is displayed, poorly, but it's here) Note that if everybody think I should revert i'll do it. I'm inclined to agree with Owen. This fix has caused numerous problems for our partners. It changes both print.css files, which is used on all the following files: INTRANET: includes/help-top.inc includes/doc-head-close-receipt.inc includes/doc-head-close.inc catalogue/detailprint.tt basket/basket.tt members/moremember-receipt.tt members/moremember-print.tt OPAC: includes/doc-head-close.inc opac-basket.tt It changes the font definition in <body>, and the widths/heights on very high-level HTML fields (not just for specific classes or IDs). This has bled through into lots of related problems. Better to revert, and find a better alternate solution. Created attachment 6609 [details] [review] Alternate fix Here's a less-drastic solution that works in my tests under Firefox 3.6 and 8 on Windows 7. As: * this problem is very annoying * has a trivial fix that i've checked I've pushed the updated fix without waiting for another signature Patch pushed, please test (it's really a crazy FF bug !!!) *** Bug 7199 has been marked as a duplicate of this bug. *** This patch was incorporated into 3.6.x prior to 3.6.4. |