Summary: | Bug in opac-reserve.pl stopping item level holds | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Cormack <chris> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | lculber, magnus |
Version: | 3.4 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 5917, 6353 | ||
Attachments: |
Proposed Patch
Screenshot of broken table Screenshot of error message 'no item was selected' Revised fix Signed-off patch |
Description
Chris Cormack
2011-05-16 21:25:53 UTC
Created attachment 4128 [details] [review] Proposed Patch Created attachment 4197 [details]
Screenshot of broken table
Patch applies, but there are some problems:
1) Table width and cells are broken once you click on specific hold.
2) When I tried to place my hold I always got 'No item was selected'.
Created attachment 4198 [details]
Screenshot of error message 'no item was selected'
Created attachment 4200 [details] [review] Revised fix Adding some changes to Chris's: - More variable scope corrections - Minor markup and style tweak - Table column span correction Created attachment 4210 [details] [review] Signed-off patch Simple template::toolkit issue, pushed please test We tested this in 3.4.1 and it worked beautifully for us. Table looks good, no error when placing hold. |