Summary: | Erroneous prefixes before the singleBranchMode preference | ||
---|---|---|---|
Product: | Koha | Reporter: | Janusz Kaczmarek <januszop> |
Component: | Templates | Assignee: | Janusz Kaczmarek <januszop> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 6347 | ||
Bug Blocks: | 5917 | ||
Attachments: |
Proposed patch
Proposed patch (with the header) [SIGNED-OFF] Bug 6353: Erroneous prefixes before the singleBranchMode preference removed |
Description
Janusz Kaczmarek
2011-05-17 15:36:59 UTC
Comment hidden (obsolete)
This patch does not apply with git: Patch format detection failed. I am marking 'Does not apply' - perhaps someone can reformat? Katrin, I have just resent the patch again to the list (yesterday my e-mail program introduced line breaks). Please test it now. Thank you. Can you attach your new patch to the bug plz? You can mark the old one obsolete, so there will be no confusion about which patch should be used. Created attachment 4181 [details] [review] Proposed patch (with the header) Hi Katrin, Could you, please, explain, why do you consider this bug as dependent on 6347? I do not get the point. It seems to me that these two bugs are fully independent. As to opac-results.tt: singleBranchMode is a "global" parameter/preference -- all I propose in my patch is removing the erroneous loop prefix from before it... Best regards! Janusz Hi Janusz, I can't test the part on reserve.tt because it applies to item level holds - which are currently broken. See here from the code: [% IF ( OPACItemHolds ) %] [% IF ( bibitemloo.holdable ) %] <tr class="copiesrow" id="copiesrow_[% bibitemloo.biblionumber %]"> <td colspan="1"> </td> <td colspan="[% bibitemloo.itemtable_colspan %]"> <table> <caption>Select a specific copy:</caption> <tr> <th>Copy</th> [% IF ( item_level_itypes ) %] <th>Item Type</th> [% END %] <th>Barcode</th> line you fixed > [% UNLESS ( bibitemloo.singleBranchMode ) %] <th>Home Library</th> <th>Last Location</th> I believe your patch works, but at the moment I can't test properly. I tried to sign off the fix for item level holds, but ran into some problems. Hope that explains. Thank you, Katrin, for the explanation--now I get the point. Created attachment 4295 [details] [review] [SIGNED-OFF] Bug 6353: Erroneous prefixes before the singleBranchMode preference removed Patch resent due to errors in formating in previous e-mail Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Checked: - library facet - library limit on advanced search - library shown in item level hold table TT error, pushed please test There have been no further reports of problems so I am marking this bug resolved. |