Summary: | Send renewal notice | ||
---|---|---|---|
Product: | Koha | Reporter: | Savitra Sirohi <savitra.sirohi> |
Component: | Circulation | Assignee: | Amit Gupta <kohapatch> |
Status: | RESOLVED DUPLICATE | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | gmcharlt, koha.sekjal, kohapatch, nengard |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Send Item renewal notice
With update DB version xxx Signed-off patch |
Description
Savitra Sirohi
2011-08-30 05:16:32 UTC
Created attachment 5353 [details] [review] Send Item renewal notice Version numbers should only be assigned by the RM. The kohaversion file shouldn't be in this patch and the updatedatabase file should not say: +$DBversion = "3.05.00.011"; it should instead say: +$DBversion = "3.05.00.XXX"; Created attachment 5373 [details] [review] With update DB version xxx Created attachment 5781 [details] [review] Signed-off patch This works well for me. The notices were sent correctly upon renewal. I wish item and issue information could be included with the notice but it looks like that's an outstanding issue with other notices as well. This patch uses GetMemberDetails() universally on every renewal, whether or not a notice will actually be generated. The only bit of information used from this expensive call is the categorycode. It would be better, therefore, to use GetMember() instead, which is a much lighter-weight subroutine and will result in less of a performance hit. For example, GetMemberDetails() includes a call to patronflags(), which calls checkoverdues(), which pulls in all the biblio, biblioitems (minus marc), items and issues data for every overdue that patron has... |