Summary: | Missing dependencies for Debian package | ||
---|---|---|---|
Product: | Koha | Reporter: | Jared Camins-Esakov <jcamins> |
Component: | Packaging | Assignee: | Robin Sheat <robin> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, gmcharlt, kyle, magnus, paul.poulain |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 7409 - add unzip and perl-doc dependencies to package
Bug 7409 - add unzip and perl-doc dependencies to package Bug 7409 : Missing dependency on libtest-mockmodule-perl Bug 7409 : Adding missing dependency Bug 7409 : Missing dependency on DBD::Mock Bug 7409 : Adding missing dependency Bug 7409 : Missing dependency on DBD::Mock |
Description
Jared Camins-Esakov
2012-01-05 23:26:14 UTC
*** Bug 7389 has been marked as a duplicate of this bug. *** Created attachment 7577 [details] [review] Bug 7409 - add unzip and perl-doc dependencies to package Note that the Koha dependency on Date::ICal will cause build errors if you have an up-to-date with testing build environment. It's unrelated to this, but may cause problems testing it. See bug 7532 for details. Created attachment 7601 [details] [review] Bug 7409 - add unzip and perl-doc dependencies to package Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Simple patch to add two important dependencies for the debian packages. Marking as Passed QA. QA comment: also REMOVE - libhtml-template-pro-perl, that we don't use anymore, it's OK, just to be full disclaiming what' in the patch ! does not look like an ENH to me, so switching to severity "normal" and version rel_3_6 The removal of that was completely automatic, it presumably was removed from the main Koha dependencies file some time in the past (which is what the control file is built from.) But yes, worth noting still. This fix was included in the 3.6.x branch prior to 3.6.4. Created attachment 12258 [details] [review] Bug 7409 : Missing dependency on libtest-mockmodule-perl Created attachment 12259 [details] [review] Bug 7409 : Adding missing dependency Created attachment 12263 [details] [review] Bug 7409 : Missing dependency on DBD::Mock Assuming that these deps are recorded in the standard dependencies file, they'll get picked up on their own, and I tend to roll them into a bigger patch, along with changelog updates and such. If not, then this patch will be needed for them. They aren't currently, which means that the 3.8.x daily builds are failing Created attachment 12423 [details] [review] Bug 7409 : Adding missing dependency Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 12424 [details] [review] Bug 7409 : Missing dependency on DBD::Mock Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> There's something wrong here. In particular, C4::Installer::PerlDependencies doesn't contain the required modules, and so they will not be included in the debian build. The debian control file is automatically generated, and shouldn't be edited by hand. I will add it to the dependencies file as part of 8806. I'll chance the status on this, as this patch really shouldn't go in in this form. These changes have been included in bug 8806, things are best done there. Does this bug need to remain open? libdbd-mock-perl was added a while back, and I'm not sure that we need a standing bug for adding new package dependencies. Nah, it should be closed. |