Bug 7782

Summary: Replace yes/no for cancelling holds with checkboxes and add delete link in patron account
Product: Koha Reporter: Owen Leonard <oleonard>
Component: CirculationAssignee: Sam Lau <samalau>
Status: Failed QA --- QA Contact: Kyle M Hall (khall) <kyle>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, heather, kebliss, kyle, samalau, veron
Version: Main   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Proposed interface for the checkout and patron detail pages' list of holds
Bug 7782: Replace yes/no dropdown with checkboxes for cancelling holds
Bug 7782: Replace yes/no dropdown with checkboxes for cancelling holds
Bug 7782: Replace yes/no dropdown with checkboxes for cancelling holds

Description Owen Leonard 2012-03-21 15:37:40 UTC
Created attachment 8438 [details]
Proposed interface for the checkout and patron detail pages' list of holds

The lists of holds on a patron's checkout and detail pages are consistent with each other, but different from the list of holds displayed for a paticular title. I think there are some features of the title's holds list which could be added to the circ and patron detail page, and some possible improvements to all of them.

The option of choosing "yes or no" is non-standard in Koha. It would be more consistent to offer the user a column of checkboxes for marking individual lines for deletion.

To the checkout and patron detail pages' list of holds I would also add a single "delete" link corresponding to the "X" icon on the title's hold list page. The redirect will have to be modified to return the user to the appropriate page.
Comment 1 Marc VĂ©ron 2015-12-20 16:39:21 UTC
Still valid?
Comment 2 Katrin Fischer 2019-03-14 07:19:00 UTC
I still really like the idea of replacing the 'yes/no' pull down with a more standard checkbox and have an additional delete link too.
Comment 3 Katrin Fischer 2023-08-04 19:24:46 UTC
I believe this would still be a great improvement!
Comment 4 Owen Leonard 2024-05-20 12:04:47 UTC
*** Bug 36896 has been marked as a duplicate of this bug. ***
Comment 5 Sam Lau 2024-06-13 20:34:06 UTC
Created attachment 167696 [details] [review]
Bug 7782: Replace yes/no dropdown with checkboxes for cancelling holds

This patch replaces the yes/no options for selecting which holds to cancel with checkboxes. Furthermore, a select all/none link was added to the column header for even easier selection.

To test:
1) Request multiple holds (at least 3) on different bibs for the same patron.
2) Visit the patrons detail page.
3) Click on the holds table tab.
4) Notice in the "Delete?" column there is a "Yes/No" dropdown option for each hold.
5) Apply patch, restart_all
6) Notice now that there is a "Cancel?" column that has "select all | none" links along with a checkbox for each hold.
7) Click the select all link ensure it works as expect. Do the same for the select none link
8) Select one hold, then press the cancel marked holds button at the bottom. Open the table again and notice the hold was removed for the table.
9) Now press the 'select all' link and press cancel marked holds. Notice that the remaining holds are removed from the table.
10) Ensure that these holds were also correctly removed from the holds tab on that particular items page.
Comment 6 Sam Lau 2024-06-13 20:34:46 UTC
Also wanted to mention that in Bug 19371, the 'Delete?' column was renamed to the 'Cancel?' column. This change was lost somewhere (Bug 33528 from my investigation). To me, it makes sense to have it say 'Cancel?' as the button you press to remove the holds says 'Cancel Marked Holds'. So, in this patch, I just changed it back to saying "Cancel?". If anyone disagrees with this change lmk and I will revert it back.
Comment 7 Lucas Gass (lukeg) 2024-06-13 20:42:28 UTC
Created attachment 167697 [details] [review]
Bug 7782: Replace yes/no dropdown with checkboxes for cancelling holds

This patch replaces the yes/no options for selecting which holds to cancel with checkboxes. Furthermore, a select all/none link was added to the column header for even easier selection.

To test:
1) Request multiple holds (at least 3) on different bibs for the same patron.
2) Visit the patrons detail page.
3) Click on the holds table tab.
4) Notice in the "Delete?" column there is a "Yes/No" dropdown option for each hold.
5) Apply patch, restart_all
6) Notice now that there is a "Cancel?" column that has "select all | none" links along with a checkbox for each hold.
7) Click the select all link ensure it works as expect. Do the same for the select none link
8) Select one hold, then press the cancel marked holds button at the bottom. Open the table again and notice the hold was removed for the table.
9) Now press the 'select all' link and press cancel marked holds. Notice that the remaining holds are removed from the table.
10) Ensure that these holds were also correctly removed from the holds tab on that particular items page.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 8 Kyle M Hall (khall) 2024-10-18 14:44:56 UTC
Created attachment 172981 [details] [review]
Bug 7782: Replace yes/no dropdown with checkboxes for cancelling holds

This patch replaces the yes/no options for selecting which holds to cancel with checkboxes. Furthermore, a select all/none link was added to the column header for even easier selection.

To test:
1) Request multiple holds (at least 3) on different bibs for the same patron.
2) Visit the patrons detail page.
3) Click on the holds table tab.
4) Notice in the "Delete?" column there is a "Yes/No" dropdown option for each hold.
5) Apply patch, restart_all
6) Notice now that there is a "Cancel?" column that has "select all | none" links along with a checkbox for each hold.
7) Click the select all link ensure it works as expect. Do the same for the select none link
8) Select one hold, then press the cancel marked holds button at the bottom. Open the table again and notice the hold was removed for the table.
9) Now press the 'select all' link and press cancel marked holds. Notice that the remaining holds are removed from the table.
10) Ensure that these holds were also correctly removed from the holds tab on that particular items page.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 9 Katrin Fischer 2024-10-24 13:23:58 UTC
Wow, the attached screenshot is old old old!
Comment 10 Katrin Fischer 2024-10-24 13:28:55 UTC
We have a problem here :(

To test:
* Add 3 holds to a patron account (I used the multi-hold feature from the catalog search results)
* Go to the patron account
* Note title of the middle hold and cancel it.
* Go back to holds list (we should stay there, but other bug)
* The hold remains and another has been cancelled.
Comment 11 Katrin Fischer 2024-10-24 13:30:00 UTC
Confirmed this works correctly in main without the patch applied.