Summary: | Replace yes/no for cancelling holds with checkboxes and add delete link in patron account | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Circulation | Assignee: | Sam Lau <samalau> |
Status: | Failed QA --- | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, heather, kebliss, kyle, samalau, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed interface for the checkout and patron detail pages' list of holds
Bug 7782: Replace yes/no dropdown with checkboxes for cancelling holds Bug 7782: Replace yes/no dropdown with checkboxes for cancelling holds Bug 7782: Replace yes/no dropdown with checkboxes for cancelling holds |
Still valid? I still really like the idea of replacing the 'yes/no' pull down with a more standard checkbox and have an additional delete link too. I believe this would still be a great improvement! *** Bug 36896 has been marked as a duplicate of this bug. *** Created attachment 167696 [details] [review] Bug 7782: Replace yes/no dropdown with checkboxes for cancelling holds This patch replaces the yes/no options for selecting which holds to cancel with checkboxes. Furthermore, a select all/none link was added to the column header for even easier selection. To test: 1) Request multiple holds (at least 3) on different bibs for the same patron. 2) Visit the patrons detail page. 3) Click on the holds table tab. 4) Notice in the "Delete?" column there is a "Yes/No" dropdown option for each hold. 5) Apply patch, restart_all 6) Notice now that there is a "Cancel?" column that has "select all | none" links along with a checkbox for each hold. 7) Click the select all link ensure it works as expect. Do the same for the select none link 8) Select one hold, then press the cancel marked holds button at the bottom. Open the table again and notice the hold was removed for the table. 9) Now press the 'select all' link and press cancel marked holds. Notice that the remaining holds are removed from the table. 10) Ensure that these holds were also correctly removed from the holds tab on that particular items page. Also wanted to mention that in Bug 19371, the 'Delete?' column was renamed to the 'Cancel?' column. This change was lost somewhere (Bug 33528 from my investigation). To me, it makes sense to have it say 'Cancel?' as the button you press to remove the holds says 'Cancel Marked Holds'. So, in this patch, I just changed it back to saying "Cancel?". If anyone disagrees with this change lmk and I will revert it back. Created attachment 167697 [details] [review] Bug 7782: Replace yes/no dropdown with checkboxes for cancelling holds This patch replaces the yes/no options for selecting which holds to cancel with checkboxes. Furthermore, a select all/none link was added to the column header for even easier selection. To test: 1) Request multiple holds (at least 3) on different bibs for the same patron. 2) Visit the patrons detail page. 3) Click on the holds table tab. 4) Notice in the "Delete?" column there is a "Yes/No" dropdown option for each hold. 5) Apply patch, restart_all 6) Notice now that there is a "Cancel?" column that has "select all | none" links along with a checkbox for each hold. 7) Click the select all link ensure it works as expect. Do the same for the select none link 8) Select one hold, then press the cancel marked holds button at the bottom. Open the table again and notice the hold was removed for the table. 9) Now press the 'select all' link and press cancel marked holds. Notice that the remaining holds are removed from the table. 10) Ensure that these holds were also correctly removed from the holds tab on that particular items page. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 172981 [details] [review] Bug 7782: Replace yes/no dropdown with checkboxes for cancelling holds This patch replaces the yes/no options for selecting which holds to cancel with checkboxes. Furthermore, a select all/none link was added to the column header for even easier selection. To test: 1) Request multiple holds (at least 3) on different bibs for the same patron. 2) Visit the patrons detail page. 3) Click on the holds table tab. 4) Notice in the "Delete?" column there is a "Yes/No" dropdown option for each hold. 5) Apply patch, restart_all 6) Notice now that there is a "Cancel?" column that has "select all | none" links along with a checkbox for each hold. 7) Click the select all link ensure it works as expect. Do the same for the select none link 8) Select one hold, then press the cancel marked holds button at the bottom. Open the table again and notice the hold was removed for the table. 9) Now press the 'select all' link and press cancel marked holds. Notice that the remaining holds are removed from the table. 10) Ensure that these holds were also correctly removed from the holds tab on that particular items page. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Wow, the attached screenshot is old old old! We have a problem here :( To test: * Add 3 holds to a patron account (I used the multi-hold feature from the catalog search results) * Go to the patron account * Note title of the middle hold and cancel it. * Go back to holds list (we should stay there, but other bug) * The hold remains and another has been cancelled. Confirmed this works correctly in main without the patch applied. |
Created attachment 8438 [details] Proposed interface for the checkout and patron detail pages' list of holds The lists of holds on a patron's checkout and detail pages are consistent with each other, but different from the list of holds displayed for a paticular title. I think there are some features of the title's holds list which could be added to the circ and patron detail page, and some possible improvements to all of them. The option of choosing "yes or no" is non-standard in Koha. It would be more consistent to offer the user a column of checkboxes for marking individual lines for deletion. To the checkout and patron detail pages' list of holds I would also add a single "delete" link corresponding to the "X" icon on the title's hold list page. The redirect will have to be modified to return the user to the appropriate page.