Bug 19371 - Change template table column text from 'Delete?' to 'Cancel?' on the patron circulation page holds tab
Summary: Change template table column text from 'Delete?' to 'Cancel?' on the patron ...
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Alex Buckley
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-27 07:32 UTC by Alex Buckley
Modified: 2017-10-09 19:19 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug: 19371: Changed table column text to 'Cancel?' on the patron circulation page (1.45 KB, patch)
2017-09-27 07:37 UTC, Alex Buckley
Details | Diff | Splinter Review
Bug: 19371: Changed table column text to 'Cancel?' on the patron circulation page (1.58 KB, patch)
2017-09-28 06:41 UTC, Marc Véron
Details | Diff | Splinter Review
Bug: 19371: Changed table column text to 'Cancel?' on the patron circulation page (1.64 KB, patch)
2017-10-06 17:53 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Buckley 2017-09-27 07:32:50 UTC
At present on the circ/circulation.tt file there is a table column header with the text: 'Delete?'

However after the user has selected the 'Yes' option in the dropdown boxes in this column then there is no button on the page with the text 'Delete' in it instead they have to click a button with the text 'Cancel marked holds'

Using both 'Delete' and 'Cancel' on the same page causes confusion and so this minor patch will change the table column text to 'Cancel?'
Comment 1 Alex Buckley 2017-09-27 07:37:20 UTC
Created attachment 67391 [details] [review]
Bug: 19371: Changed table column text to 'Cancel?' on the patron circulation page

Test plan:
1. Place a hold on an item

2. Search for the patron who the hold is associated with

3. View the Hold(s) tab of the Checkouts page and notice there is a
column with the text 'Delete?' and a button below the table with the
text 'Cancel marked holds'

4. Apply patch

5. Notice that the column text described in step 3 now has the text
'Cancel?' and the button text is the same as it was in step 3

Sponsored-By: Catalyst IT
Comment 2 Marc Véron 2017-09-28 06:41:35 UTC
Created attachment 67425 [details] [review]
Bug: 19371: Changed table column text to 'Cancel?' on the patron circulation page

Test plan:
1. Place a hold on an item

2. Search for the patron who the hold is associated with

3. View the Hold(s) tab of the Checkouts page and notice there is a
column with the text 'Delete?' and a button below the table with the
text 'Cancel marked holds'

4. Apply patch

5. Notice that the column text described in step 3 now has the text
'Cancel?' and the button text is the same as it was in step 3

Sponsored-By: Catalyst IT

Signed-off-by: Marc Véron <veron@veron.ch>
Comment 3 Nick Clemens 2017-10-06 17:53:45 UTC
Created attachment 67755 [details] [review]
Bug: 19371: Changed table column text to 'Cancel?' on the patron circulation page

Test plan:
1. Place a hold on an item

2. Search for the patron who the hold is associated with

3. View the Hold(s) tab of the Checkouts page and notice there is a
column with the text 'Delete?' and a button below the table with the
text 'Cancel marked holds'

4. Apply patch

5. Notice that the column text described in step 3 now has the text
'Cancel?' and the button text is the same as it was in step 3

Sponsored-By: Catalyst IT

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Jonathan Druart 2017-10-09 19:19:37 UTC
Pushed to master for 17.11, thanks to everybody involved!